Merge pull request #3 from Oyshoboy/improved-basic-interaction

nailuj05 · web-flow · commit e66f8acb1464 · 2022-05-12T18:23:28.000+02:00
Improved difference calculation in BasicFluidInteractor.cs
Thank you for contributing :)
diff --git a/Scripts/BasicFluidInteractor.cs b/Scripts/BasicFluidInteractor.cs
@@ -8,7 +8,8 @@ public class BasicFluidInteractor : BaseFluidInteractor
     {
         public override void FluidUpdate()
         {
-            float difference = transform.position.y - fluid.transform.position.y;
+            var fluidSurface = fluid.coll ? fluid.coll.bounds.max.y : fluid.transform.position.y;
+            float difference = transform.position.y - fluidSurface;
 
             if(difference < 0)
             {

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,8 @@ public class BasicFluidInteractor : BaseFluidInteractor`
`8`	`8`	`{`
`9`	`9`	`public override void FluidUpdate()`
`10`	`10`	`{`
`11`		`- float difference = transform.position.y - fluid.transform.position.y;`
	`11`	`+ var fluidSurface = fluid.coll ? fluid.coll.bounds.max.y : fluid.transform.position.y;`
	`12`	`+ float difference = transform.position.y - fluidSurface;`
`12`	`13`
`13`	`14`	`if(difference < 0)`
`14`	`15`	`{`