From 39c0a587d0ba7c1a634693636a1ac862697be715 Mon Sep 17 00:00:00 2001 From: Sergei Churilo Date: Fri, 30 Jul 2021 11:31:56 +0300 Subject: [PATCH 1/2] Use vendor/bin/phpcs in composer scripts --- composer.json | 2 +- tests/Functional/TagCommandsTest.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index 8cb2b1069..cb8567a67 100644 --- a/composer.json +++ b/composer.json @@ -129,7 +129,7 @@ "vendor/bin/robo coverage ./docs/TestCoverage.md" ], "cs": [ - "phpcs --standard=tests/config/linting_ruleset.xml bin/t3 src" + "vendor/bin/phpcs --standard=tests/config/linting_ruleset.xml bin/t3 src tests/Functional" ], "docs": [ "vendor/bin/robo doc ./README.md", diff --git a/tests/Functional/TagCommandsTest.php b/tests/Functional/TagCommandsTest.php index 8fb2f844e..2f5c204e6 100644 --- a/tests/Functional/TagCommandsTest.php +++ b/tests/Functional/TagCommandsTest.php @@ -28,7 +28,7 @@ class TagCommandsTest extends TestCase * @group short */ public function testTagAddListRemove() - { + { $siteName = getenv('TERMINUS_SITE'); $orgId = getenv('TERMINUS_ORG'); $newTag = uniqid("tag-"); From 944eab8b0c54cb3df67d03d0655f7fd2310bd80c Mon Sep 17 00:00:00 2001 From: Sergei Churilo Date: Fri, 30 Jul 2021 15:24:05 +0300 Subject: [PATCH 2/2] Add "Validate Code" step to CI "Checkout & build Phar" phase --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6046e4264..473a61524 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,6 +25,8 @@ jobs: path: /home/runner/work/terminus/terminus - name: Full Composer Install run: composer install + - name: Validate Code + run: composer code:lint - name: Phar Build run: composer phar:build - name: permissions