Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for simple definition of title and description #17

Open
Citrullin opened this issue Oct 24, 2021 · 0 comments
Open

Allow for simple definition of title and description #17

Citrullin opened this issue Oct 24, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Citrullin
Copy link
Collaborator

If I understand it correctly, the definition of title and description is at the moment always derived from the default language. However, there might be cases where you want to reuse a thing model that has a predefined title or description and no language specific titlesor descriptions.

I would therefore suggest that we offer the possibility to define both title and description on their own with the current (very nice) solution as a potential fallback.

Also (partly) fixed by 02a1de4: title and description are matched with/inserted as the field for the defined @language ("en" if @language is not defined).

@Citrullin: You've mentioned that you've intended to allow to switch the default language at runtime. I guess to allow for that we need some kind of mechanism to ensure that this language will actually be defined at runtime.

Maybe we could define the supported languages in the Makefile which are then passed on to the python script. There we could check if all titles and descriptions contain all specified languages.

@Citrullin Citrullin added the enhancement New feature or request label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant