Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for access tokens regarding cnf claims #21

Open
pulsastrix opened this issue Aug 4, 2024 · 0 comments
Open

Fix documentation for access tokens regarding cnf claims #21

pulsastrix opened this issue Aug 4, 2024 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@pulsastrix
Copy link
Member

pulsastrix commented Aug 4, 2024

I am unsure if the examples we currently provide for access tokens (in lib.rs and token/mod.rs) are actually valid, as we A: send a symmetric key in a signed (i.e. non-encrypted) COSE structure, and B: do not wrap the key in the cnf claim as specified in RFC 9200, section 5 (which references RFC 8747, section 3.1).

Maybe we need to update these examples in general, however, this might also be a candidate for a separate PR, as it is not strictly related to the COSE stuff we add here.

Originally posted by @pulsastrix in #13 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants