Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining statements (last, map, reset, secmark) #70

Open
jwhb opened this issue Oct 21, 2024 · 0 comments · May be fixed by #76
Open

Implement remaining statements (last, map, reset, secmark) #70

jwhb opened this issue Oct 21, 2024 · 0 comments · May be fixed by #76
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jwhb
Copy link
Member

jwhb commented Oct 21, 2024

Is your feature request related to a problem? Please describe.
There are some statements that are apparently undocumented but implemented in libnftables-json that are not implemented by this crate.
Some users brought this to our attention: #15 #41 #4 #65.

The following issues may arise:

  • panic/error during deserialization when nft json output contains these statements
  • user unable to create nftables object with these statements

Describe the solution you'd like

  1. Mark crate::stmt::Statement enum as non-exhaustive to avoid breaking changes when new statements are added.
    Originally posted by @JKRhb in Implement SynProxy #29 (comment)
  2. Implement remaining statements to be compatible with libnftables-rs.

Describe alternatives you've considered
n/a

Additional context
Missing statements are already marked here.

@jwhb jwhb added the enhancement New feature or request label Oct 21, 2024
@jwhb jwhb self-assigned this Oct 21, 2024
This was referenced Oct 21, 2024
@jwhb jwhb changed the title Implement remaining statements (last, flow, map, reset, secmark) Implement remaining statements (last, map, reset, secmark) Oct 21, 2024
@jwhb jwhb added this to the v0.6.0 milestone Oct 21, 2024
@jwhb jwhb linked a pull request Oct 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant