From b37a82dba5ac4a4398165c1ba68722399f049109 Mon Sep 17 00:00:00 2001 From: Kentaro Ohkouchi Date: Wed, 26 Jul 2023 23:53:10 +0900 Subject: [PATCH] Support Chrome for Testing on *NIX --- .github/workflows/test.yml | 12 ++++++-- lib/setup-chromedriver.sh | 57 ++++++++++++++++++++++++++++++++++---- 2 files changed, 61 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 9160b7fb..62b8c659 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -23,6 +23,7 @@ jobs: matrix: os: [ ubuntu-latest, ubuntu-20.04, macos-latest, macos-11 ] branch: [ 'master', 'now' ] + chrome_version: [ 'current', '114.0.5735.90' ] steps: - uses: actions/checkout@v3 - if: startsWith(matrix.os, 'ubuntu') @@ -37,9 +38,16 @@ jobs: node_modules/.bin/tsc $GITHUB_WORKSPACE/__tests__/chromedriver.ts node_modules/.bin/ncc build $GITHUB_WORKSPACE/__tests__/chromedriver.js -o $GITHUB_WORKSPACE/__tests__ rm -rf node_modules - - run: | - CHROME_VERSION=$("$CHROMEAPP" --version | cut -f 3 -d ' ' | cut -d '.' -f 1) + - if: matrix.chrome_version != 'current' + env: + CHROME_VERSION: ${{ matrix.chrome_version }} + run: | + CHROME_VERSION=$(echo $CHROME_VERSION | cut -d '.' -f 1) echo "CHROMEDRIVER_VERSION=$(curl --location --fail --retry 10 http://chromedriver.storage.googleapis.com/LATEST_RELEASE_${CHROME_VERSION})" >> $GITHUB_ENV + - if: matrix.chrome_version == 'current' + run: | + CHROME_VERSION=$("$CHROMEAPP" --version | cut -f 3 -d ' ') + echo "CHROMEDRIVER_VERSION=$CHROME_VERSION" >> $GITHUB_ENV - uses: ./ if: matrix.branch == 'now' with: diff --git a/lib/setup-chromedriver.sh b/lib/setup-chromedriver.sh index a2cf18e5..5a5974b0 100755 --- a/lib/setup-chromedriver.sh +++ b/lib/setup-chromedriver.sh @@ -7,9 +7,28 @@ ARCH=$2 if [ "$ARCH" == "linux64" ]; then CHROMEAPP=google-chrome + if ! type -a sudo > /dev/null 2>&1; then + apt-get update + apt-get install -y sudo + fi + if ! type -a curl > /dev/null 2>&1; then + sudo apt-get update + sudo apt-get install -y curl + fi if ! type -a google-chrome > /dev/null 2>&1; then + curl -O https://dl.google.com/linux/direct/google-chrome-stable_current_amd64f.deb + sudo apt install -y ./google-chrome-stable_current_amd64.deb + + # sudo apt-get update + # sudo apt-get install -y google-chrome + fi + if ! type -a jq > /dev/null 2>&1; then + sudo apt-get update + sudo apt-get install -y jq + fi + if ! type -a bc > /dev/null 2>&1; then sudo apt-get update - sudo apt-get install -y google-chrome + sudo apt-get install -y bc fi elif [ "$ARCH" == "mac64" ]; then CHROMEAPP="/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" @@ -17,10 +36,36 @@ fi if [ "$VERSION" == "" ]; then CHROME_VERSION=$("$CHROMEAPP" --version | cut -f 3 -d ' ' | cut -d '.' -f 1) - VERSION=$(curl --location --fail --retry 10 http://chromedriver.storage.googleapis.com/LATEST_RELEASE_${CHROME_VERSION}) +else + CHROME_VERSION=$(echo "$VERSION" | cut -d '.' -f 1) fi -wget -c -nc --retry-connrefused --tries=0 https://chromedriver.storage.googleapis.com/${VERSION}/chromedriver_${ARCH}.zip -unzip -o -q chromedriver_${ARCH}.zip -sudo mv chromedriver /usr/local/bin/chromedriver -rm chromedriver_${ARCH}.zip +UNDER115=$(echo "$CHROME_VERSION < 115" | bc) +if [ "$UNDER115" -eq 1 ]; then + if [ "$VERSION" == "" ]; then + VERSION=$(curl --location --fail --retry 10 http://chromedriver.storage.googleapis.com/LATEST_RELEASE_${CHROME_VERSION}) + fi + echo "Installing ChromeDriver $VERSION for $ARCH" + + curl --location --fail --retry 10 -O https://chromedriver.storage.googleapis.com/${VERSION}/chromedriver_${ARCH}.zip + unzip -o -q chromedriver_${ARCH}.zip + rm chromedriver_${ARCH}.zip +else + if [ "$VERSION" == "" ]; then + VERSION=$("$CHROMEAPP" --version | cut -f 3 -d ' ') + fi + if [ "$ARCH" == "mac64" ]; then + ARCH="mac-x64" + fi + + echo "Installing ChromeDriver $VERSION for $ARCH" + URL=$(curl --location --fail --retry 10 https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json | jq -r ".versions[] | select(.version == \"${VERSION}\") | .downloads.chromedriver[] | select(.platform == \"${ARCH}\") | .url") + echo "Downloading $URL" + curl --location --fail --retry 10 -O "$URL" + unzip -o -q chromedriver-${ARCH}.zip + sudo mv chromedriver-${ARCH}/chromedriver /usr/local/bin/chromedriver + rm chromedriver-${ARCH}.zip + rm -r chromedriver-${ARCH} +fi + +