Skip to content

Unexpected BIPM warning when used with NG20 default (BIPM2023) #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rossjjennings opened this issue Nov 26, 2024 · 2 comments
Closed

Comments

@rossjjennings
Copy link
Member

Currently, running through the NANOGrav 20-year notebook with bipm in the configuration file set to BIPM2023 gives the following warning:

WARNING: Wrong bipm_version (BIPM2023); should be BIPM2021. [pint_pal.par_checker]

#63 was supposed to have taken care of this (via the pint_pal_project.yaml in the NG20 repository), but it doesn't seem to be working: par_checker is still using recommendations from PINT Pal's defaults.yaml instead of the NG20 ones.

@JPGlaser
Copy link
Collaborator

JPGlaser commented Jan 23, 2025

@rossjjennings did this get corrected in the pre-holiday busy time?

~ Joe G.

@rossjjennings
Copy link
Member Author

It turned out not to be an issue with PINT Pal per se, so much as an issue with the notebook, which is in the data set repo. The notebook was missing a line like

pint_pal.set_data_root('.')

That's now added in the NG20 repo, so I consider this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants