From 83d18af151be661e54149509b062a6ad06820eab Mon Sep 17 00:00:00 2001 From: Adam Shurson Date: Sat, 13 Apr 2019 11:09:46 -0500 Subject: [PATCH] Revise android module to return the biometry type supported (instead of boolean) --- TouchID.android.js | 4 ++-- .../main/java/com/rnfingerprint/FingerprintAuthModule.java | 5 ++++- index.d.ts | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/TouchID.android.js b/TouchID.android.js index 297c24d2..b88e3c33 100644 --- a/TouchID.android.js +++ b/TouchID.android.js @@ -10,8 +10,8 @@ export default { (error, code) => { return reject(createError(config, error, code)); }, - success => { - return resolve(true); + (biometryType) => { + return resolve(biometryType); } ); }); diff --git a/android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java b/android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java index dc54baba..cc0c1de0 100644 --- a/android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java +++ b/android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java @@ -59,7 +59,10 @@ public void isSupported(final Callback reactErrorCallback, final Callback reactS int result = isFingerprintAuthAvailable(); if (result == FingerprintAuthConstants.IS_SUPPORTED) { - reactSuccessCallback.invoke("Is supported."); + // TODO: once this package supports Android's Face Unlock, + // implement a method to find out which type of biometry + // (not just fingerprint) is actually supported + reactSuccessCallback.invoke("Fingerprint"); } else { reactErrorCallback.invoke("Not supported.", result); } diff --git a/index.d.ts b/index.d.ts index 797233a2..581c49f7 100644 --- a/index.d.ts +++ b/index.d.ts @@ -2,7 +2,7 @@ declare module 'react-native-touch-id' { /** * The supported biometry type */ - type BiometryType = 'FaceID' | 'TouchID'; + type BiometryType = 'FaceID' | 'TouchID' | 'Fingerprint'; /** * Base config to pass to `TouchID.isSupported` and `TouchID.authenticate`