From 465a1c7ff806c99282e19fd6e715ad6c672dba1d Mon Sep 17 00:00:00 2001 From: Marco Edward Gorelli Date: Wed, 7 Aug 2024 17:46:41 +0100 Subject: [PATCH] ci: fix import error from dask test (#737) * ci: fix import error from dask test * fix --- tests/frame/add_test.py | 6 +----- tests/translate/from_native_test.py | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/frame/add_test.py b/tests/frame/add_test.py index 20927f37e..b885bb05d 100644 --- a/tests/frame/add_test.py +++ b/tests/frame/add_test.py @@ -1,14 +1,10 @@ from typing import Any -import pytest - import narwhals.stable.v1 as nw from tests.utils import compare_dicts -def test_add(constructor: Any, request: Any) -> None: - if "dask" in str(constructor): - request.applymarker(pytest.mark.xfail) +def test_add(constructor: Any) -> None: data = {"a": [1, 3, 2], "b": [4, 4, 6], "z": [7.0, 8, 9]} df = nw.from_native(constructor(data)) result = df.with_columns( diff --git a/tests/translate/from_native_test.py b/tests/translate/from_native_test.py index d6ee5473d..af49c0226 100644 --- a/tests/translate/from_native_test.py +++ b/tests/translate/from_native_test.py @@ -191,7 +191,7 @@ def test_series_only_dask() -> None: ) def test_eager_only_lazy_dask(eager_only: Any, context: Any) -> None: pytest.importorskip("dask") - pytest.importorskip("dask_expr") + pytest.importorskip("dask_expr", exc_type=ImportError) import dask.dataframe as dd dframe = dd.from_pandas(df_pd)