From 58c1b23afccc5bc666929451367565b79a910449 Mon Sep 17 00:00:00 2001 From: Liam Connors Date: Sun, 8 Sep 2024 18:50:30 -0400 Subject: [PATCH] Revert "xfail to_arrow tests for cuDF" This reverts commit d695efd210fb30b2e2e5beea84a67d25836f152b. --- tests/frame/to_arrow_test.py | 2 -- tests/series_only/to_arrow_test.py | 11 +++-------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/tests/frame/to_arrow_test.py b/tests/frame/to_arrow_test.py index 7966c3f12..c1f395e59 100644 --- a/tests/frame/to_arrow_test.py +++ b/tests/frame/to_arrow_test.py @@ -14,8 +14,6 @@ def test_to_arrow(request: Any, constructor_eager: Any) -> None: if "pandas" in str(constructor_eager) and parse_version(pd.__version__) < (1, 0, 0): # pyarrow requires pandas>=1.0.0 request.applymarker(pytest.mark.xfail) - if "cudf" in str(constructor_eager): - request.applymarker(pytest.mark.xfail) data = {"a": [1, 3, 2], "b": [4, 4, 6], "z": [7.1, 8, 9]} df_raw = constructor_eager(data) diff --git a/tests/series_only/to_arrow_test.py b/tests/series_only/to_arrow_test.py index dce15867b..ebd90b7c2 100644 --- a/tests/series_only/to_arrow_test.py +++ b/tests/series_only/to_arrow_test.py @@ -9,10 +9,7 @@ import narwhals.stable.v1 as nw -def test_to_arrow(constructor_eager: Any, request: Any) -> None: - if "cudf" in str(constructor_eager): - request.applymarker(pytest.mark.xfail) - +def test_to_arrow(constructor_eager: Any) -> None: data = [1, 2, 3] result = nw.from_native(constructor_eager({"a": data}), eager_only=True)[ "a" @@ -23,10 +20,8 @@ def test_to_arrow(constructor_eager: Any, request: Any) -> None: def test_to_arrow_with_nulls(constructor_eager: Any, request: Any) -> None: - if ( - "pandas_constructor" in str(constructor_eager) - or "modin_constructor" in str(constructor_eager) - or "cudf" in str(constructor_eager) + if "pandas_constructor" in str(constructor_eager) or "modin_constructor" in str( + constructor_eager ): request.applymarker(pytest.mark.xfail)