test typing

Author: FBruzzesi

tests/expr_and_series/is_between_test.py

@@ -1,5 +1,7 @@
 from __future__ import annotations
 
+from typing import Literal
+
 import pytest
 
 import narwhals.stable.v1 as nw
@@ -17,7 +19,11 @@
         ("none", [False, True, True, False]),
     ],
 )
-def test_is_between(constructor: Constructor, closed: str, expected: list[bool]) -> None:
+def test_is_between(
+    constructor: Constructor,
+    closed: Literal["left", "right", "none", "both"],
+    expected: list[bool],
+) -> None:
     data = {"a": [1, 4, 2, 5]}
     df = nw.from_native(constructor(data))
     result = df.select(nw.col("a").is_between(1, 5, closed=closed))
@@ -43,7 +49,9 @@ def test_is_between_expressified(constructor: Constructor) -> None:
     ],
 )
 def test_is_between_series(
-    constructor_eager: ConstructorEager, closed: str, expected: list[bool]
+    constructor_eager: ConstructorEager,
+    closed: Literal["left", "right", "none", "both"],
+    expected: list[bool],
 ) -> None:
     data = {"a": [1, 4, 2, 5]}
     df = nw.from_native(constructor_eager(data), eager_only=True)

tests/spark_like_test.py

@@ -9,6 +9,7 @@
 from contextlib import nullcontext as does_not_raise
 from typing import TYPE_CHECKING
 from typing import Any
+from typing import Literal
 
 import pandas as pd
 import pytest
@@ -991,7 +992,9 @@ def test_clip(pyspark_constructor: Constructor) -> None:
     ],
 )
 def test_is_between(
-    pyspark_constructor: Constructor, closed: str, expected: list[bool]
+    pyspark_constructor: Constructor,
+    closed: Literal["left", "right", "none", "both"],
+    expected: list[bool],
 ) -> None:
     data = {"a": [1, 4, 2, 5]}
     df = nw.from_native(pyspark_constructor(data))