Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: investigate cudf failure in explode_test #1650

Open
MarcoGorelli opened this issue Dec 23, 2024 · 0 comments
Open

test: investigate cudf failure in explode_test #1650

MarcoGorelli opened this issue Dec 23, 2024 · 0 comments

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Dec 23, 2024

here's what the traceback shows

____________ test_explode_invalid_operation_error[cudf_constructor] ____________

request = <FixtureRequest for <Function test_explode_invalid_operation_error[cudf_constructor]>>
constructor = <function cudf_constructor at 0x7c284b3d2680>

    def test_explode_invalid_operation_error(
        request: pytest.FixtureRequest, constructor: Constructor
    ) -> None:
        if "dask" in str(constructor) or "pyarrow_table" in str(constructor):
            request.applymarker(pytest.mark.xfail)
    
        if "polars" in str(constructor) and POLARS_VERSION < (0, 20, 6):
            request.applymarker(pytest.mark.xfail)
    
        with pytest.raises(
            (InvalidOperationError, PlInvalidOperationError),
            match="`explode` operation not supported for dtype",
        ):
>           _ = nw.from_native(constructor(data)).lazy().explode("a").collect()

tests/frame/explode_test.py:146: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
narwhals/dataframe.py:5045: in explode
    return super().explode(columns, *more_columns)
narwhals/dataframe.py:342: in explode
    self._compliant_frame.explode(
narwhals/_pandas_like/dataframe.py:972: in explode
    schema = self.collect_schema()
narwhals/_pandas_like/dataframe.py:339: in collect_schema
    return self.schema
narwhals/_pandas_like/dataframe.py:331: in schema
    return {
narwhals/_pandas_like/dataframe.py:332: in <dictcomp>
    col: native_to_narwhals_dtype(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

native_column = 0    [1, 2]
1      None
2    [None]
3        []
Name: l1, dtype: list
version = <Version.V1: 1>, implementation = <Implementation.CUDF: 3>

    def native_to_narwhals_dtype(
        native_column: Any, version: Version, implementation: Implementation
    ) -> DType:
        dtype = str(native_column.dtype)
    
        dtypes = import_dtypes_module(version)
    
        if dtype.startswith(("large_list", "list", "struct", "fixed_size_list")):
>           return arrow_native_to_narwhals_dtype(native_column.dtype.pyarrow_dtype, version)
E           AttributeError: 'ListDtype' object has no attribute 'pyarrow_dtype'

narwhals/_pandas_like/utils.py:449: AttributeError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant