Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rewrite agg_pandas to use NamedAgg #1661

Open
MarcoGorelli opened this issue Dec 26, 2024 · 3 comments
Open

chore: rewrite agg_pandas to use NamedAgg #1661

MarcoGorelli opened this issue Dec 26, 2024 · 3 comments
Labels
internal

Comments

@MarcoGorelli
Copy link
Member

Since cuDF have introduced NamedAgg, we can probably refactor the agg_pandas function to use NamedAgg. It may simplify things a bit, and avoid going via duplicate column names

This would just be an internal refactor
@FBruzzesi
Copy link
Member

That would be really nice!

My concern is that to end up with a dedicated path for modin, wouldn't we?
(I could not find anything documenting modin support for NamedAgg)

@MarcoGorelli
Copy link
Member Author

looks like they have it

In [13]: import modin.pandas as mpd

In [14]: mpd.NamedAgg
Out[14]: pandas.core.groupby.generic.NamedAgg

@FBruzzesi
Copy link
Member

Then... I am all in for it 😁🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarcoGorelli @FBruzzesi