Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dask nightly #1768

Merged
merged 1 commit into from
Jan 9, 2025
Merged

chore: dask nightly #1768

merged 1 commit into from
Jan 9, 2025

Conversation

FBruzzesi
Copy link
Member

@FBruzzesi FBruzzesi commented Jan 8, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@@ -684,7 +684,10 @@ def _from_native_impl( # noqa: PLR0915
msg = "Cannot only use `eager_only` or `eager_or_interchange_only` with dask DataFrame"
raise TypeError(msg)
return native_object
if get_dask_expr() is None: # pragma: no cover
if (
parse_version(get_dask().__version__) <= (2024, 12, 1)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change this to the next release version as soon as it's available

@FBruzzesi FBruzzesi marked this pull request as ready for review January 9, 2025 07:32
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @FBruzzesi !

@MarcoGorelli MarcoGorelli merged commit 40a83e3 into main Jan 9, 2025
24 checks passed
@MarcoGorelli MarcoGorelli deleted the chore/dask-nightly branch January 9, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: dask-nightly is failing
2 participants