Minor bug fixes for spectra_generator #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
troyraen
commented
Dec 13, 2024
troyraen
commented
- Commit data/ and output/ directories, empty except for READMEs. (These are already ignored in .gitignore to prevent actual data files from being committed.)
- In plotting function, make sure output/ dir exists before writing to it.
- Add a target so DESIBOSS_get_spec returns data
troyraen
added
bug
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
Minor bug fixes for spectra_generator 260dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.