adjusting linting settings

nasa-jpl · Jun 26, 2024 · 29afed6 · 29afed6
1 parent 1a0fa51
commit 29afed6
Show file tree

Hide file tree

Showing 8 changed files with 128 additions and 96 deletions.
diff --git a/apps/vue-storybook/package.json b/apps/vue-storybook/package.json
@@ -14,8 +14,10 @@
     "build": "storybook build -c .storybook -o storybook_compiled",
     "percy": "percy storybook http://localhost:6006",
     "percy:dry-run": "percy storybook http://localhost:6006 --dry-run",
-    "lint": "eslint ./stories",
-    "lint:fix": "eslint ./stories --fix",
+    "lint:app": "eslint './.storybook/**/*.@(js|ts)'",
+    "lint:app:fix": "eslint './.storybook/**/*.@(js|ts)' --fix",
+    "lint": "eslint './../../packages/vue/src/**/*.stories.@(js|ts|mdx)' && pnpm lint:app",
+    "lint:fix": "eslint './../../packages/vue/src/**/*.stories.@(js|ts|mdx)' --fix && pnpm lint:app:fix",
     "init-msw": "msw init public/"
   },
   "dependencies": {

diff --git a/packages/configs/eslint/index.js b/packages/configs/eslint/index.js
@@ -20,7 +20,7 @@ const __dirname = path.dirname(__filename)
 const compat = new FlatCompat({
   baseDirectory: __dirname,
   recommendedConfig: {}, // Add recommendedConfig property
-  allConfig: {}, // Add allConfig property
+  allConfig: {} // Add allConfig property
 })
 
 export default [
@@ -37,29 +37,22 @@ export default [
       '**/*.ts',
       '**/*.tsx',
       '**/*.cts',
-      '**/*.mts',
-    ],
-    ignores: [
-      '**/*.d.ts',
-      '**/dist/**/*',
-      '**/dist/**/*',
-      '**/.nuxt/*',
-      '**/node_modules/**/*',
-      '.gitignore',
+      '**/*.mts'
     ],
+    ignores: ['**/*.d.ts', '**/dist/**/*', '**/.nuxt/*', '**/node_modules/**/*', '.gitignore'],
     plugins: {
       '@typescript-eslint': tsPlugin,
-      '@stylistic': stylistic,
+      '@stylistic': stylistic
     },
     languageOptions: {
       parser: vueParser,
       parserOptions: {
-        parser: tsParser,
+        parser: tsParser
       },
-      ecmaVersion: 'latest',
+      ecmaVersion: 'latest'
     },
     rules: {
-      'semi': 'off',
+      semi: 'off',
       '@stylistic/semi': ['warn', 'never'],
       // allow async-await
       'generator-star-spacing': 'off',
@@ -69,7 +62,7 @@ export default [
       'no-void': 'off',
       'multiline-ternary': 'off',
       'no-unused-vars': 'warn',
-      
+
       'no-undef': 'warn',
 
       'prefer-promise-reject-errors': 'off',
@@ -78,11 +71,7 @@ export default [
       'vue/multi-word-component-names': 'warn',
 
       // TypeScript
-      quotes: [
-        'warn',
-        'single',
-        { avoidEscape: true, allowTemplateLiterals: true },
-      ],
+      quotes: ['warn', 'single', { avoidEscape: true, allowTemplateLiterals: true }],
       '@typescript-eslint/explicit-function-return-type': 'off',
       '@typescript-eslint/explicit-module-boundary-types': 'off',
       '@typescript-eslint/no-unnecessary-type-assertion': 'off',
@@ -98,8 +87,8 @@ export default [
       'storybook/prefer-pascal-case': 'off',
       'storybook/story-exports': 'off',
       'vue/singleline-html-element-content-newline': 'off',
-      'vue/max-attributes-per-line': 'off',
-    },
+      'vue/max-attributes-per-line': 'off'
+    }
   },
-  eslintPluginPrettierRecommended,
+  eslintPluginPrettierRecommended
 ]
diff --git a/packages/configs/eslint/package.json b/packages/configs/eslint/package.json
@@ -8,6 +8,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "prettier": "@explorer-1/prettier-config",
   "devDependencies": {
     "@eslint/eslintrc": "^3.1.0",
     "@eslint/js": "^9.3.0",
@@ -21,4 +22,4 @@
     "eslint-plugin-vue": "^9.26.0",
     "vue-eslint-parser": "^9.4.2"
   }
-}
+}
diff --git a/packages/nuxt/playground/app.vue b/packages/nuxt/playground/app.vue
@@ -2,80 +2,87 @@
   <div class="relative">
     <base-heading size="h1">Nuxt Module Playground</base-heading>
     <div class="text-center mb-3">
-      <base-button variant="primary">
-        Button component
-      </base-button>
+      <base-button variant="primary"> Button component </base-button>
     </div>
-    <block-image class="relative" :data="BlockImageData" />
+    <block-image
+      class="relative"
+      :data="BlockImageData"
+    />
     <p>This is a paragraph, not a component.</p>
-    <hero-media :image="{
-      url: 'https://picsum.photos/1440/620',
-      width: 1440,
-      height: 620
-    }" />
-    <detail-headline title="NASA's Ingenuity Mars Helicopter Recharges Its Batteries in Flight" publication-date="2020-08-13" :topics="[
-      {
-        title: 'Mars',
-        url: '/topics/mars'
-      },
-      {
-        title: 'Rover',
-        url: '/topics/rover'
-      }
-    ]" />
+    <hero-media
+      :image="{
+        url: 'https://picsum.photos/1440/620',
+        width: 1440,
+        height: 620
+      }"
+    />
+    <detail-headline
+      title="NASA's Ingenuity Mars Helicopter Recharges Its Batteries in Flight"
+      publication-date="2020-08-13"
+      :topics="[
+        {
+          title: 'Mars',
+          url: '/topics/mars'
+        },
+        {
+          title: 'Rover',
+          url: '/topics/rover'
+        }
+      ]"
+    />
     <mission-detail-highlights
       :animation="true"
       heading="Heading"
       mission-title="UAD"
       :highlights="[
-    {
-      date: '1983-01-21',
-      heading: 'Launch',
-      highlightLink: {
-        externalLink: null,
-        page: {
-          title: 'Color Picture from Spirit is Most Detailed View of Mars Ever Seen',
-          url: '/news/from-russia-with-grace/'
-        }
-      },
-      summary: 'A successful launch happened.'
-    },
-    {
-      date: '1983-06-08',
-      heading: null,
-      highlightLink: {
-        externalLink: null,
-        page: {
-          title: 'Color Picture from Spirit is Most Detailed View of Mars Ever Seen',
-          url: '/news/from-russia-with-grace/'
+        {
+          date: '1983-01-21',
+          heading: 'Launch',
+          highlightLink: {
+            externalLink: null,
+            page: {
+              title: 'Color Picture from Spirit is Most Detailed View of Mars Ever Seen',
+              url: '/news/from-russia-with-grace/'
+            }
+          },
+          summary: 'A successful launch happened.'
+        },
+        {
+          date: '1983-06-08',
+          heading: null,
+          highlightLink: {
+            externalLink: null,
+            page: {
+              title: 'Color Picture from Spirit is Most Detailed View of Mars Ever Seen',
+              url: '/news/from-russia-with-grace/'
+            }
+          },
+          summary: null
+        },
+        {
+          date: '1983-11-21',
+          heading: 'End of mission',
+          highlightLink: {
+            externalLink: 'https://www.nasa.gov',
+            page: null
+          },
+          summary:
+            'Following a 10-month-long mission, the space telescope exhausts its cryogen and ceases operations.'
         }
-      },
-      summary: null
-    },
-    {
-      date: '1983-11-21',
-      heading: 'End of mission',
-      highlightLink: {
-        externalLink: 'https://www.nasa.gov',
-        page: null
-      },
-      summary:
-        'Following a 10-month-long mission, the space telescope exhausts its cryogen and ceases operations.'
-    }
-  ]"
+      ]"
+    />
+    <block-cta
+      :data="{
+        heading: 'Call to action',
+        text: 'CTA',
+        page: '',
+        externalLink: 'http://www.jpl.nasa.gov'
+      }"
     />
-    <block-cta :data="{
-      heading: 'Call to action',
-      text: 'CTA',
-      page: '',
-      externalLink: 'http://www.jpl.nasa.gov'
-    }" />
-
   </div>
 </template>
 
 <script setup>
-
 const BlockImageData = {
   blockType: 'FullBleedImageBlock',
   fullBleed: false,

diff --git a/packages/nuxt/playground/eslint.config.mjs b/packages/nuxt/playground/eslint.config.mjs
@@ -0,0 +1,3 @@
+import withNuxt from './.nuxt/eslint.config.mjs'
+import config from '@explorer-1/eslint-config'
+export default withNuxt().prepend(config)
diff --git a/packages/nuxt/playground/nuxt.config.ts b/packages/nuxt/playground/nuxt.config.ts
@@ -1,5 +1,5 @@
 export default defineNuxtConfig({
-  modules: ['../src/module'],
+  modules: ['@nuxt/eslint', '../src/module'],
   explorer1: {},
   devtools: { enabled: true }
 })
diff --git a/packages/nuxt/playground/package.json b/packages/nuxt/playground/package.json
@@ -2,12 +2,19 @@
   "private": true,
   "name": "my-module-playground",
   "type": "module",
+  "prettier": "@explorer-1/prettier-config",
   "scripts": {
     "dev": "nuxi dev",
     "build": "nuxi build",
-    "generate": "nuxi generate"
+    "generate": "nuxi generate",
+    "lint": "eslint",
+    "lint:fix": "eslint --fix"
   },
   "dependencies": {
     "nuxt": "^3.11.2"
+  },
+  "devDependencies": {
+    "@nuxt/eslint": "^0.3.13",
+    "@explorer-1/eslint-config": "workspace:*"
   }
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml