Skip to content

Commit

Permalink
fixing accessibility issues in SearchInput
Browse files Browse the repository at this point in the history
  • Loading branch information
stephiescastle committed Sep 12, 2024
1 parent 6790386 commit 31d8391
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions packages/vue/src/components/SearchInput/SearchInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ onMounted(() => {
:class="{
'text-gray-dark': defaultColors,
'py-1': underlinedInput,
'py-3.5 lg:py-6': !underlinedInput
'py-3.5 lg:py-5': !underlinedInput
}"
type="search"
aria-label="Query"
Expand All @@ -86,7 +86,8 @@ onMounted(() => {
/>
<button
v-if="withButton"
class="hover:cursor-pointer bg-action p-4 lg:p-5 border border-white"
class="z-10 cursor-pointer bg-action p-4 lg:p-5 border border-white"
aria-label="Search resources"
@click="emit('submit')"
>
<IconSearch class="relative z-10 text-xl sm:text-2xl lg:text-3xl text-white" />
Expand Down
2 changes: 1 addition & 1 deletion packages/vue/src/templates/edu/PageEduHome/PageEduHome.vue
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const submitSearch = () => {
>
<BaseLink
variant="none"
:to="`/edu/resources?topic=${topic.page?.title}`"
:to="`/edu/resources?query=${topic.page?.title}`"
link-class="text-gray-dark whitespace-nowrap text-sm bg-[#99D1DF] font-extrabold rounded-full inline-block px-3 py-1 text-contrast-none hover:bg-action hover:text-white"
>
{{ topic.page?.title }}
Expand Down

0 comments on commit 31d8391

Please sign in to comment.