fixing logic for VideoEmbedBlock in resource article page

nasa-jpl · Jul 23, 2024 · 400a6db · 400a6db
1 parent 98a9e83
commit 400a6db
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/packages/vue/package.json b/packages/vue/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@explorer-1/vue",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "private": false,
   "publishConfig": {
     "access": "public"

diff --git a/packages/vue/src/components/BlockVideoEmbed/BlockVideoEmbed.stories.js b/packages/vue/src/components/BlockVideoEmbed/BlockVideoEmbed.stories.js
@@ -9,6 +9,7 @@ export default {
 // shared data
 export const BlockVideoEmbedData = {
   data: {
+    blockType: 'VideoEmbedBlock',
     embed: {
       embed: `<iframe title="Meet NASA's Diana Trujillo" width="480" height="270" src="https://www.youtube.com/embed/vUuUyYqI83Q?feature=oembed" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>`
     },

diff --git a/packages/vue/src/templates/PageNewsDetail/PageNewsDetail.vue b/packages/vue/src/templates/PageNewsDetail/PageNewsDetail.vue
@@ -208,6 +208,7 @@ export default defineComponent({
         } else if (
           this.data?.heroPosition === 'inline' ||
           this.data?.hero[0].blockType === 'CarouselBlock'
+          // TODO: should this match PageEduResourceArticle and also check for VideoEmbedBlock?
         ) {
           return true
         }

diff --git a/packages/vue/src/templates/edu/PageEduResourceArticle/PageEduResourceArticle.vue b/packages/vue/src/templates/edu/PageEduResourceArticle/PageEduResourceArticle.vue
@@ -46,13 +46,28 @@ export default defineComponent({
           return false
         } else if (
           this.data?.heroPosition === 'inline' ||
-          this.data?.hero[0].blockType === 'CarouselBlock'
+          this.data?.hero[0].blockType === 'CarouselBlock' ||
+          this.data?.hero[0].blockType === 'VideoEmbedBlock'
         ) {
           return true
         }
       }
       return false
     },
+    // heroInline(): boolean {
+    //   if (!this.heroEmpty) {
+    //     const type = this.data?.hero[0].blockType
+    //     if (type === 'VideoBlock' || type === 'VideoEmbedBlock') {
+    //       return false
+    //     } else if (
+    //       this.data?.heroPosition === 'inline' ||
+    //       this.data?.hero[0].blockType === 'CarouselBlock'
+    //     ) {
+    //       return true
+    //     }
+    //   }
+    //   return false
+    // },
     computedClass(): string {
       if (this.heroInline || this.heroEmpty) {
         return 'pt-5 lg:pt-12'
@@ -108,7 +123,7 @@ export default defineComponent({
         :label="data.displayLabel"
         schema
       />
-      <share-buttons-edu
+      <ShareButtonsEdu
         v-if="data?.url"
         class="mt-4"
         :url="data.url"