fixing jump menu links in mobile menu, adding readtime to teachable m…

…oments, fixing about the author heading spacing (#575)
nasa-jpl · Aug 28, 2024 · 4172976 · 4172976
1 parent 268308d
commit 4172976
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 6 deletions.
diff --git a/packages/vue/src/components/AboutTheAuthor/AboutTheAuthor.vue b/packages/vue/src/components/AboutTheAuthor/AboutTheAuthor.vue
@@ -28,7 +28,7 @@ const headingString = computed(() => {
 </script>
 <template>
   <div class="AboutTheAuthor">
-    <h3 class="text-h4 sm:ml-[130px] pl-10 mb-6">
+    <h3 class="text-h4 sm:ml-[130px] sm:pl-10 mb-6">
       {{ headingString }}
     </h3>
     <template

diff --git a/packages/vue/src/interfaces.ts b/packages/vue/src/interfaces.ts
@@ -223,6 +223,7 @@ export interface PageObject {
   slug: string
   url: string
   title: string
+  readTime?: string
   getTopicsForDisplay?: Topic[]
   showJumpMenu?: boolean
   label?: string

diff --git a/packages/vue/src/templates/edu/PageEduCollectionsDetail/PageEduCollectionsDetail.vue b/packages/vue/src/templates/edu/PageEduCollectionsDetail/PageEduCollectionsDetail.vue
@@ -63,10 +63,10 @@ const computedClass = computed((): string => {
     />
 
     <NavJumpMenu
+      v-if="data.showJumpMenu"
       ref="PageEduCollectionsDetailJumpMenu"
       :title="data.title"
       :blocks="data.body"
-      :enabled="data.showJumpMenu"
       dropdown-text="In this collection"
     />
 

diff --git a/packages/vue/src/templates/edu/PageEduExplainerArticle/PageEduExplainerArticle.vue b/packages/vue/src/templates/edu/PageEduExplainerArticle/PageEduExplainerArticle.vue
@@ -120,9 +120,9 @@ export default defineComponent({
     </LayoutHelper>
 
     <NavJumpMenu
+      v-if="data.showJumpMenu"
       :title="data.title"
       :blocks="data.body"
-      :enabled="data.showJumpMenu"
       dropdown-text="In this article"
     />
     <!-- inline hero content -->

diff --git a/packages/vue/src/templates/edu/PageEduLesson/PageEduLesson.vue b/packages/vue/src/templates/edu/PageEduLesson/PageEduLesson.vue
@@ -326,7 +326,6 @@ const consolidatedSections = computed((): EduLessonSectionObject[] => {
       ref="PageEduLessonJumpMenu"
       :title="data.title"
       :blocks="consolidatedBlocks"
-      :enabled="true"
       dropdown-text="In this lesson"
     />
 

diff --git a/packages/vue/src/templates/edu/PageEduNewsDetail/PageEduNewsDetail.vue b/packages/vue/src/templates/edu/PageEduNewsDetail/PageEduNewsDetail.vue
@@ -69,10 +69,10 @@ defineExpose({
     itemtype="http://schema.org/Article"
   >
     <NavJumpMenu
+      v-if="data.showJumpMenu"
       ref="PageEduNewsDetailJumpMenu"
       :title="data.title"
       :blocks="data.body"
-      :enabled="data.showJumpMenu"
       dropdown-text="In this news article"
     />
 

diff --git a/packages/vue/src/templates/edu/PageEduTeachableMoment/PageEduTeachableMoment.stories.js b/packages/vue/src/templates/edu/PageEduTeachableMoment/PageEduTeachableMoment.stories.js
@@ -42,6 +42,7 @@ export const BaseStory = {
       url: 'http://localhost:3000/edu/resources/teachable-moment',
       pageType: 'EDUTeachableMomentPage',
       contentType: 'edu_resources.EDUTeachableMomentPage',
+      readTime: '5 min read',
       showJumpMenu: true,
       thumbnailImage: {
         __typename: 'CustomImage',

diff --git a/packages/vue/src/templates/edu/PageEduTeachableMoment/PageEduTeachableMoment.vue b/packages/vue/src/templates/edu/PageEduTeachableMoment/PageEduTeachableMoment.vue
@@ -67,10 +67,10 @@ const computedClass = computed((): string => {
     :class="computedClass"
   >
     <NavJumpMenu
+      v-if="data.showJumpMenu"
       ref="PageEduTeachableMomentJumpMenu"
       :title="data.title"
       :blocks="data.body"
-      :enabled="data.showJumpMenu"
       dropdown-text="In this Teachable Moment"
     />
 
@@ -97,6 +97,7 @@ const computedClass = computed((): string => {
     >
       <DetailHeadline
         :title="data.title"
+        :read-time="data.readTime"
         label="Teachable Moment"
         pill
       />