Skip to content

Commit

Permalink
fixes edu secondary nav offset, fixes dayjs import
Browse files Browse the repository at this point in the history
  • Loading branch information
stephiescastle committed Jul 29, 2024
1 parent 8163c7b commit b2e7f9c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
10 changes: 8 additions & 2 deletions packages/vue/src/components/NavSecondary/NavSecondary.vue
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export default defineComponent({
<style lang="scss">
.NavSecondary {
top: -1px; // for intersection observer to work
@apply sticky z-50 w-full bg-white border-b edu:border-0 border-gray-mid border-opacity-0 transition-border-opacity duration-150 ease-in;
@apply sticky z-40 w-full bg-white border-b edu:border-0 border-gray-mid border-opacity-0 transition-border-opacity duration-150 edu:duration-300 ease-in;
@apply hidden;
@screen lg {
@apply block;
Expand Down Expand Up @@ -184,8 +184,14 @@ export default defineComponent({
}
}
@screen lg {
@apply top-28 edu:top-18;
@apply top-28;
}
}
}
// since we depend on a body class, the edu: prefix won't work as usual and requires the below line
body.header-sticky-showing .ThemeEdu .NavSecondary {
@screen lg {
@apply top-[4.45rem];
}
}
</style>
3 changes: 2 additions & 1 deletion packages/vue/src/utils/filters.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import dayjs from './dayjs'
// must include `.js`
import dayjs from './dayjs.js'

const filters = {
// To support more locales update add imports to dayjs.js'
Expand Down

0 comments on commit b2e7f9c

Please sign in to comment.