From c344b6b5082a21133cb71b52ca5dc116c4a3f208 Mon Sep 17 00:00:00 2001 From: Stephanie Smith Date: Thu, 18 Jul 2024 17:03:01 -0700 Subject: [PATCH] removing default size from BaseHeading (#504) --- .../vue/src/components/BaseHeading/BaseHeading.vue | 2 +- .../vue/src/components/BlockHeading/BlockHeading.vue | 1 - .../BlockStreamfield/BlockStreamfield.stories.js | 10 ++++++++++ 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/packages/vue/src/components/BaseHeading/BaseHeading.vue b/packages/vue/src/components/BaseHeading/BaseHeading.vue index 2c5a11c6..b63ce458 100644 --- a/packages/vue/src/components/BaseHeading/BaseHeading.vue +++ b/packages/vue/src/components/BaseHeading/BaseHeading.vue @@ -26,7 +26,7 @@ export default defineComponent({ size: { type: String as PropType, required: false, - default: 'h2', + default: '', validator: (prop: string): boolean => Object.keys(headings).includes(prop) } }, diff --git a/packages/vue/src/components/BlockHeading/BlockHeading.vue b/packages/vue/src/components/BlockHeading/BlockHeading.vue index 46e637aa..fe3dfb45 100644 --- a/packages/vue/src/components/BlockHeading/BlockHeading.vue +++ b/packages/vue/src/components/BlockHeading/BlockHeading.vue @@ -2,7 +2,6 @@ {{ data.heading }} diff --git a/packages/vue/src/components/BlockStreamfield/BlockStreamfield.stories.js b/packages/vue/src/components/BlockStreamfield/BlockStreamfield.stories.js index 633c5199..4d5a1aa3 100644 --- a/packages/vue/src/components/BlockStreamfield/BlockStreamfield.stories.js +++ b/packages/vue/src/components/BlockStreamfield/BlockStreamfield.stories.js @@ -49,6 +49,16 @@ export const BlockStreamfieldData = { '

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque vitae justo quis justo malesuada molestie. Cras sed tincidunt dui.

Integer imperdiet blandit neque vitae euismod. Nulla aliquet lacus nibh, vel tincidunt urna efficitur non. In et eros vitae ex posuere maximus quis eget urna. Suspendisse fringilla posuere velit sit amet posuere. Morbi malesuada bibendum vehicula. Donec faucibus ut erat ut mattis. Suspendisse ornare, quam at placerat cursus, dolor mi lacinia nunc, eget maximus augue nulla in dolor.

\n' }, BlockInlineImageData.block, + { + blockType: 'HeadingBlock', + heading: 'Heading 2', + level: 'h2' + }, + { + blockType: 'HeadingBlock', + heading: 'Heading 3', + level: 'h3' + }, { blockType: 'RichTextBlock', value: