fixing ts errors

nasa-jpl · Sep 15, 2024 · cfbfb57 · cfbfb57
1 parent f2aecd6
commit cfbfb57
Showing 1 changed file with 22 additions and 9 deletions.
diff --git a/packages/vue/src/components/PodcastSeriesCarousel/PodcastSeriesCarousel.vue b/packages/vue/src/components/PodcastSeriesCarousel/PodcastSeriesCarousel.vue
@@ -46,7 +46,7 @@
         :initial-slide="
           activeSeasonId === initialSeasonId && initialEpisodeIndex ? initialEpisodeIndex : 0
         "
-        :slides="activeTabData.episodes"
+        :slides="activeTabData.episodes as Partial<Slide>[]"
       />
     </keep-alive>
   </div>
@@ -61,6 +61,12 @@ import ThumbnailCarousel from './../ThumbnailCarousel/ThumbnailCarousel.vue'
 
 const route = useRoute()
 
+interface Slide {
+  url: string
+  title: string
+  thumbnailImage: Partial<ImageObject>
+}
+
 interface Episode {
   url: string
   title: string
@@ -74,15 +80,15 @@ interface ActiveTab {
 }
 
 interface Season {
-  id?: string
+  id: string
   url?: string
   title?: string
   seasonNumber?: number
   episodes?: Episode[]
 }
 
 interface Series {
-  id?: string
+  id: string
   title?: string
   url?: string
   seasons?: Season[]
@@ -112,11 +118,16 @@ export default defineComponent({
     }
   },
   computed: {
-    sortedSeasons(): Season[] | null {
+    sortedSeasons(): Season[] | undefined {
       let seasons = undefined
       if (this.series && this.series.seasons) {
         seasons = this.series.seasons
-        seasons = seasons.toSorted((a: Season, b: Season) => a.seasonNumber - b.seasonNumber)
+        // @ts-expect-error seasons is an array
+        seasons = seasons.toSorted((a: Season, b: Season) => {
+          if (a.seasonNumber && b.seasonNumber) {
+            return a.seasonNumber - b.seasonNumber
+          }
+        })
         return seasons
       }
       return seasons
@@ -156,10 +167,12 @@ export default defineComponent({
         }
         if (season?.episodes?.length) {
           let episodes: Episode[] = season.episodes
-          episodes = episodes.toSorted(
-            (a: Episode, b: Episode) =>
-              new Date(a.publicationDate).getTime() - new Date(b.publicationDate).getTime()
-          )
+          // @ts-expect-error episodes is an array
+          episodes = episodes.toSorted((a: Episode, b: Episode) => {
+            if (a.publicationDate && b.publicationDate) {
+              return new Date(a.publicationDate).getTime() - new Date(b.publicationDate).getTime()
+            }
+          })
           season = {
             ...season,
             episodes: episodes