Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize icon sizes #27

Open
stephiescastle opened this issue Sep 27, 2021 · 0 comments
Open

Standardize icon sizes #27

stephiescastle opened this issue Sep 27, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@stephiescastle
Copy link
Member

stephiescastle commented Sep 27, 2021 •
edited
Loading

Icon sizes use ems for width and height. About half of our icons use 1em as the base size, but several others use 2.75em. And a handful use even more specific overrides.

It would be worthwhile to standardize the SVGs to use a base size of 1em. We could then remove the scss files for all of the icons and set a global default instead.
@stephiescastle stephiescastle added the enhancement New feature or request label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephiescastle