Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circleimage / milestone card component #409

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

albinazs
Copy link
Contributor

@albinazs albinazs commented Jul 29, 2023

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
    to do after the type and the naming of the component are approved
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

In this PR I've implemented the CircleImage component, part of the www-frontend Timeline page:

  • used BaseImagePlaceholder and 'BadeHeading' components to make use of the built-in features
  • added prop type to control the image position. Defaults to the left
  • added props to control the content: required title and label, as well as optional secondaryLabel
  • structured CSS in a way that allows to control the image position not just by props, but by direct CSS declarations to make it easier to use ion pages like www- Timeline
  • size and positioning of the component are not hard-coded and will be handled when the component is used on the actual page
  • on click function will also be added when the component is used on the actual page
Screenshots image image image image

Instructions to test

check the BackToTop story in the Storybook

Tested in the following environments/browsers:

Operating System

  • MacOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@github-actions github-actions bot added feature storybook This issue relates to Storybook.js labels Jul 29, 2023
@albinazs albinazs marked this pull request as ready for review July 31, 2023 17:44
@albinazs
Copy link
Contributor Author

albinazs commented Aug 3, 2023

@Scotchester ready for review with the updated docs

@Scotchester Scotchester added the minor Contains new features or enhancements label Aug 14, 2023
Copy link
Member

@Scotchester Scotchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@albinazs albinazs force-pushed the feature/component-milestone-card branch from 07c4027 to 536f80d Compare August 15, 2023 12:43
@albinazs albinazs merged commit 7686a7e into main Aug 15, 2023
1 check passed
@albinazs albinazs deleted the feature/component-milestone-card branch August 15, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature minor Contains new features or enhancements storybook This issue relates to Storybook.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants