Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating npm to 16.20.2 #427

Merged
merged 5 commits into from
May 7, 2024
Merged

Updating npm to 16.20.2 #427

merged 5 commits into from
May 7, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented May 2, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Instructions to test

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@github-actions github-actions bot added the maintenance The meta work of maintaining the project label May 2, 2024
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@stephiescastle
Copy link
Member Author

Noting a dependency issue that I'll look into Monday:

 npm ERR! While resolving: @tailwindcss/forms@0.5.0
npm ERR! Found: tailwindcss@2.2.19
npm ERR! node_modules/tailwindcss
npm ERR!   tailwindcss@"^2.2.19" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer tailwindcss@">=3.0.0 || >= 3.0.0-alpha.1" from @tailwindcss/forms@0.5.0
npm ERR! node_modules/@tailwindcss/forms
npm ERR!   @tailwindcss/forms@"^0.5.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: tailwindcss@3.4.3
npm ERR! node_modules/tailwindcss
npm ERR!   peer tailwindcss@">=3.0.0 || >= 3.0.0-alpha.1" from @tailwindcss/forms@0.5.0
npm ERR!   node_modules/@tailwindcss/forms
npm ERR!     @tailwindcss/forms@"^0.5.0" from the root project
npm ERR! 

@stephiescastle
Copy link
Member Author

Noting a dependency issue that I'll look into Monday

Now fixed.

@stephiescastle
Copy link
Member Author

My comment markup is confusing, but what I intended to suggest was that another approach we took could be to just widen the compatibility instead of upgrading explorer-1:

    "node": "^14.19.0",
    "npm": "^6.14.16"

Note the addition of the carets rather than bumping version numbers.

I'm pro-upgrading but the suggestion above would be less disruptive for other projects that use explorer-1.

@Scotchester
Copy link
Member

Dev page and Storybook are both working fine. While testing, I noticed that Placekitten has run out of lives 😿 so I standardized all of our placeholder images to use https://picsum.photos.

One thing I noticed is that after building for Storybook, the built CSS and JS had some minor changes. Think we should go ahead and include those?

My comment markup is confusing, but what I intended to suggest was that another approach we took could be to just widen the compatibility instead of upgrading explorer-1:

    "node": "^14.19.0",
    "npm": "^6.14.16"

Note the addition of the carets rather than bumping version numbers.

I'm pro-upgrading but the suggestion above would be less disruptive for other projects that use explorer-1.

I agree we should press on. 16 is already EOL, too, so this should just be considered a stepping stone to 18 and 20. As far as we know, our projects are the only ones that consume explorer-1, right? I don't feel bad about forcing our own projects to upgrade if they want to upgrade explorer-1.

@stephiescastle
Copy link
Member Author

Thanks @Scotchester, I've updated the build files.

@stephiescastle stephiescastle merged commit 4293f13 into main May 7, 2024
1 check passed
@stephiescastle stephiescastle deleted the chore/update-node-16.20.2 branch May 7, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The meta work of maintaining the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants