Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: monorepo eslint upgrade to flat config #435

Merged
merged 4 commits into from
May 24, 2024
Merged

Feature: monorepo eslint upgrade to flat config #435

merged 4 commits into from
May 24, 2024

Conversation

jamesray
Copy link
Member 

modified:   .github/workflows/lint.yml
modified:   .npmrc
modified:   Makefile
modified:   apps/html-storybook/package.json
deleted:    apps/vue-storybook/.eslintrc.cjs
new file:   apps/vue-storybook/.gitignore
modified:   apps/vue-storybook/package.json
new file:   eslint.config.js
modified:   package.json
modified:   packages/common-storybook/package.json
modified:   packages/common-storybook/src/config/customTheme.ts
modified:   packages/common-storybook/src/config/withGlobals.ts
modified:   packages/common/package.json
modified:   packages/common/tailwind.config.js
new file:   packages/configs/eslint/index.js
new file:   packages/configs/eslint/package.json
deleted:    packages/html/package-lock.json
modified:   packages/html/package.json
modified:   packages/nuxt/package.json
modified:   packages/nuxt/src/module.ts
modified:   packages/vue/package.json
modified:   packages/vue/src/components/BaseButton/BaseButton.vue
modified:   pnpm-lock.yaml

@github-actions github-actions bot added feature maintenance The meta work of maintaining the project storybook This issue relates to Storybook.js labels May 24, 2024
@jamesray jamesray changed the base branch from main to feature/monorepo May 24, 2024 10:45
stephiescastle
stephiescastle approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@stephiescastle stephiescastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks @jamesray!

@stephiescastle stephiescastle merged commit f40d553 into feature/monorepo May 24, 2024
1 check passed
@stephiescastle stephiescastle deleted the feature/monorepo_eslint branch May 24, 2024 17:26
stephiescastle added a commit that referenced this pull request May 24, 2024
@stephiescastle @jamesray
Feature: convert to monorepo, add a vue library and nuxt module (#432)
1ce4e9d 
* converting monorepo (pnpm workspaces)

* fixing symlinks issue in mdx

* fixing ts config in packages/html

* small fixes to tailwind config and mdx render

* unifying prettier config and tsconfig

* prototyping how to share story data between storybooks

* completing @explorer-1/vue package

* completing @explorer-1/storybook-vue app

* updating makefile

* switching vue vite to library mode

* adding @explorer-1/nuxt module

* adding module to makefile, minor cleanup

* fixing duplicate modules in vite

* fixing make commands, building module

* removing ignored dist

* updating gitignore

* renaming storybook-* to *-storybook

* updating Storybook to 8.1.2

* wip updating github workflow for pnpm

* adding @explorer-1/common-storybook

* disabling linting in ci (temporary), fixing storybook action

* restore some linting actions

* updating gitignore

* adding gitkeep for public folder

* Feature: monorepo eslint upgrade to flat config (#435)

* adds .history folder to gitignore

* linting passes

* remove old eslint config files

* remove --debug from eslint cli

* convert packages/html to use vite instead of parcel

parcel cleanup

---------

Co-authored-by: James Ray <james.a.ray@jpl.nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephiescastle stephiescastle stephiescastle approved these changes

Assignees
No one assigned
Labels
feature maintenance The meta work of maintaining the project storybook This issue relates to Storybook.js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesray @stephiescastle