Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: edu news detail component #469

Merged
merged 9 commits into from
Jun 25, 2024
Merged

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Jun 25, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Supports https://github.com/nasa-jpl/www/issues/28

Adds:

  • Share Buttons EDU component w/ stories
  • EDU News Detail component w/ stories

Notes:

Caveats

The "Google Classroom" share link isn't complete (getting clarification).

Instructions to test

  1. make storybook
  2. View http://localhost:6006/?path=/story/components-edu-sharebuttonsedu--default&globals=theme:ThemeEdu
  3. View http://localhost:6006/?path=/story/templates-edu-pageedunewsdetail--edu-news-detail&globals=theme:ThemeEdu

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle changed the title feature: edu news detail page feature: edu news detail component Jun 25, 2024
@stephiescastle stephiescastle added the patch Contains bug fixes or maintenance work label Jun 25, 2024
@stephiescastle stephiescastle merged commit c680d01 into main Jun 25, 2024
1 check passed
@stephiescastle stephiescastle deleted the feature/news-detail-page branch June 25, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants