Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/workaround for nuxt module #475

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Fix/workaround for nuxt module #475

merged 5 commits into from
Jun 28, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Jun 28, 2024

This PR addresses issues with the nuxt module when publishing to npm.

The solution is a workaround:

  • The nuxt module is still not operational
  • I did set up exports for @explorer-1/vue in this commit. Calling this out in case we want to revisit doing this in the future.
  • I decided to revert the export changes to the @explorer-1/vue package and instead use it directly in @www/frontend in a local module. This was the path of least resistance that would allow us to continue working in a dev env.

To test

  1. pnpm i
  2. make vue-storybook to make sure storybook and components still work

@github-actions github-actions bot added the bug Something isn't working label Jun 28, 2024
@stephiescastle stephiescastle changed the title Fix/remove nuxt module Fix/workaround for nuxt module Jun 28, 2024
@stephiescastle stephiescastle merged commit 3a50775 into main Jun 28, 2024
2 checks passed
@stephiescastle stephiescastle deleted the fix/remove-nuxt-module branch June 28, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant