Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: MetaPanel, BlockAccordion, EduLessonPage #548

Merged
merged 19 commits into from
Aug 19, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Aug 19, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Supports:

This PR:

  • Adds BaseAccordionItem and BlockAccordion FE components (BaseAccordionItem was needed for MetaPanel)
  • Adds MetaPanel component (uses basis of BlockAccordion)
  • Adds EduLessonPage template component
  • Adjustments to NavJumpMenu and NavSecondary (now tested with live data)
  • Modifies HeroMedia for EDU to hide both the caption and credit if "display caption" is unchecked
  • Adds package vue-bind-once, as we needed an SSR friendly way to generate ids (used for aria tags)

Instructions to test

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle added the patch Contains bug fixes or maintenance work label Aug 19, 2024
Copy link
Member

@jamesray jamesray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 looks good

@stephiescastle stephiescastle merged commit 826938a into main Aug 19, 2024
8 checks passed
@stephiescastle stephiescastle deleted the feature/190-meta-panels branch August 19, 2024 20:51
@stephiescastle stephiescastle mentioned this pull request Aug 19, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants