Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/vue-v0.2.49 #605

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Fix/vue-v0.2.49 #605

merged 6 commits into from
Sep 9, 2024

Conversation

jamesray
Copy link
Member

@jamesray jamesray commented Sep 9, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Changelog

458ed31 - Fixes Homepage MissionsCarousel

  • Fixed issues with the MissionsCarousel on the homepage to improve functionality and make it display in v3.

ac45b3c - Disables Highlight on Carousel Items

  • Disabled the highlight selection on carousel items to prevent unintended highlighting when dragging.

d8a5f05 - Quick Fix for ShareButtons on Curated Galleries

  • Applied a quick fix for the ShareButtons on curated galleries to ensure proper functionality.

4f441c5 - Fixes MissionsCarousel and Featured Robots on History Navigation

  • Fixed issues with both the MissionsCarousel and Featured Robots components when navigating through history pages.

a501de3 - Fix Link on PageImageDetail

  • Corrected the link handling on the PageImageDetail component.

Instructions to test

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@github-actions github-actions bot added the bug Something isn't working label Sep 9, 2024
Copy link
Member

@stephiescastle stephiescastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple clean-up suggestions, not blockers though.

@jamesray jamesray merged commit 1c29259 into main Sep 9, 2024
6 checks passed
@jamesray jamesray deleted the fix/vue-v0.2.49 branch September 9, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants