From 458ed31cb283bc7965bc690cb27d1bda54850599 Mon Sep 17 00:00:00 2001
From: James Ray <james.a.ray@jpl.nasa.gov>
Date: Mon, 9 Sep 2024 02:59:35 -0700
Subject: [PATCH 1/6] fixes homepage missionsCarousel

---
 .../HomepageMissionsCarousel.vue              |  2 +-
 .../HomepageMissionsCarouselItem.vue          | 66 +++++++------
 .../www/PageHomepage/PageHomepage.vue         | 99 ++++++++++---------
 3 files changed, 86 insertions(+), 81 deletions(-)

diff --git a/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarousel.vue b/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarousel.vue
index 9e0a0586..ff6fbd4d 100644
--- a/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarousel.vue
+++ b/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarousel.vue
@@ -30,7 +30,7 @@
         </div>
         <div class="lg:order-2 xl:px-0 flex justify-end order-3 col-start-10 col-end-13 px-4">
           <BaseLink
-            :to="{ name: 'missions' }"
+            to="/missions/"
             variant="primary"
           >
             {{ `All Missions` }}
diff --git a/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarouselItem.vue b/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarouselItem.vue
index 0145098b..9553bffd 100644
--- a/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarouselItem.vue
+++ b/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarouselItem.vue
@@ -1,9 +1,43 @@
+<script lang="ts">
+// HomepageMissionsCarouselItem.vue
+/* Slide for the homepage missions carousel.
+   Links to the topic page if provided,
+   otherwise links to mission target as fallback.
+*/
+import { defineComponent } from 'vue'
+import BaseLink from './../BaseLink/BaseLink.vue'
+import IconCaret from './../Icons/IconCaret.vue'
+
+export default defineComponent({
+  name: 'HomepageMissionsCarouselItem',
+  components: {
+    BaseLink,
+    IconCaret
+  },
+  props: {
+    data: {
+      type: Object,
+      required: false,
+      default: undefined
+    }
+  },
+  computed: {
+    hasTopic(): boolean {
+      if (this.data && this.data.topic && this.data.topic.url) {
+        return true
+      }
+      return false
+    }
+  }
+})
+</script>
+
 <template>
   <BaseLink
     v-if="data"
     variant="none"
     :aria-label="hasTopic ? 'More about ' + data.topic.title : 'View ' + data.name + ' missions'"
-    :to="hasTopic ? data.topic.url : { name: 'missions', query: { mission_target: data.name } }"
+    :to="hasTopic ? data.topic.url : '/missions/?mission_target=' + data.name"
     class="HomepageMissionsCarouselItem group flex h-full pb-1 text-white"
     link-class="flex flex-col w-full"
   >
@@ -50,37 +84,7 @@
     </div>
   </BaseLink>
 </template>
-<script lang="ts">
-/* Slide for the homepage missions carousel.
-   Links to the topic page if provided,
-   otherwise links to mission target as fallback.
-*/
-import { defineComponent } from 'vue'
-import BaseLink from './../BaseLink/BaseLink.vue'
-import IconCaret from './../Icons/IconCaret.vue'
 
-export default defineComponent({
-  name: 'HomepageMissionsCarouselItem',
-  components: {
-    BaseLink,
-    IconCaret
-  },
-  props: {
-    data: {
-      type: Object,
-      required: false
-    }
-  },
-  computed: {
-    hasTopic(): boolean {
-      if (this.data && this.data.topic && this.data.topic.url) {
-        return true
-      }
-      return false
-    }
-  }
-})
-</script>
 <style lang="scss">
 .HomepageMissionsCarouselItem {
   .text-wrapper {
diff --git a/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue b/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue
index d247f819..cf861e71 100755
--- a/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue
+++ b/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue
@@ -1,3 +1,51 @@
+<script lang="ts">
+import { defineComponent } from 'vue'
+import HomepageCarousel from './../../../components/HomepageCarousel/HomepageCarousel.vue'
+import HomepageFeaturedRobot from './../../../components/HomepageFeaturedRobot/HomepageFeaturedRobot.vue'
+import HomepageTeaserBlock from './../../../components/HomepageTeaserBlock/HomepageTeaserBlock.vue'
+import BlockLinkCarousel from './../../../components/BlockLinkCarousel/BlockLinkCarousel.vue'
+import BlockQuote from './../../../components/BlockQuote/BlockQuote.vue'
+import LayoutHelper from './../../../components/LayoutHelper/LayoutHelper.vue'
+import SwimlaneCTA from './../../../components/SwimlaneCTA/SwimlaneCTA.vue'
+import HomepageMissionsCarousel from './../../../components/HomepageMissionsCarousel/HomepageMissionsCarousel.vue'
+import HomepageStats from './../../../components/HomepageStats/HomepageStats.vue'
+import HomepageEmbedBlock from './../../../components/HomepageEmbedBlock/HomepageEmbedBlock.vue'
+
+export default defineComponent({
+  name: 'PageHomepage',
+  components: {
+    HomepageCarousel,
+    HomepageFeaturedRobot,
+    HomepageTeaserBlock,
+    BlockLinkCarousel,
+    BlockQuote,
+    LayoutHelper,
+    SwimlaneCTA,
+    HomepageMissionsCarousel,
+    HomepageStats,
+    HomepageEmbedBlock
+  },
+  props: {
+    data: {
+      type: Object,
+      required: false,
+      default: undefined
+    }
+  },
+  computed: {
+    theNews(): any[] | undefined {
+      // check first for featured news
+      if (this.data?.featuredNews?.length) {
+        return this.data.featuredNews
+      } else if (this.data?.latestNews?.length) {
+        return this.data.latestNews
+      }
+      return undefined
+    }
+  }
+})
+</script>
+
 <template>
   <div
     v-if="data"
@@ -60,8 +108,8 @@
 
     <!-- mission carousel -->
     <HomepageMissionsCarousel
-      v-if="data?.missionsCarousel?.targets?.length"
-      :data="data.missionsCarousel"
+      v-if="data?.missionsCarousel[0]?.targets?.length"
+      :data="data.missionsCarousel[0]"
       class="lg:my-18 my-10"
     />
 
@@ -87,50 +135,3 @@
     <SwimlaneCTA />
   </div>
 </template>
-<script lang="ts">
-import { defineComponent } from 'vue'
-import HomepageCarousel from './../../../components/HomepageCarousel/HomepageCarousel.vue'
-import HomepageFeaturedRobot from './../../../components/HomepageFeaturedRobot/HomepageFeaturedRobot.vue'
-import HomepageTeaserBlock from './../../../components/HomepageTeaserBlock/HomepageTeaserBlock.vue'
-import BlockLinkCarousel from './../../../components/BlockLinkCarousel/BlockLinkCarousel.vue'
-import BlockQuote from './../../../components/BlockQuote/BlockQuote.vue'
-import LayoutHelper from './../../../components/LayoutHelper/LayoutHelper.vue'
-import SwimlaneCTA from './../../../components/SwimlaneCTA/SwimlaneCTA.vue'
-import HomepageMissionsCarousel from './../../../components/HomepageMissionsCarousel/HomepageMissionsCarousel.vue'
-import HomepageStats from './../../../components/HomepageStats/HomepageStats.vue'
-import HomepageEmbedBlock from './../../../components/HomepageEmbedBlock/HomepageEmbedBlock.vue'
-
-export default defineComponent({
-  name: 'PageHomepage',
-  components: {
-    HomepageCarousel,
-    HomepageFeaturedRobot,
-    HomepageTeaserBlock,
-    BlockLinkCarousel,
-    BlockQuote,
-    LayoutHelper,
-    SwimlaneCTA,
-    HomepageMissionsCarousel,
-    HomepageStats,
-    HomepageEmbedBlock
-  },
-  props: {
-    data: {
-      type: Object,
-      required: false,
-      default: undefined
-    }
-  },
-  computed: {
-    theNews(): any[] | undefined {
-      // check first for featured news
-      if (this.data?.featuredNews?.length) {
-        return this.data.featuredNews
-      } else if (this.data?.latestNews?.length) {
-        return this.data.latestNews
-      }
-      return undefined
-    }
-  }
-})
-</script>

From ac45b3c73e3b5c837af3ead9052c1a6fdb0b71d8 Mon Sep 17 00:00:00 2001
From: James Ray <james.a.ray@jpl.nasa.gov>
Date: Mon, 9 Sep 2024 06:42:08 -0700
Subject: [PATCH 2/6] disables highlight on carousel items

---
 .../HomepageMissionsCarousel/HomepageMissionsCarousel.vue       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarousel.vue b/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarousel.vue
index ff6fbd4d..4df32c70 100644
--- a/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarousel.vue
+++ b/packages/vue/src/components/HomepageMissionsCarousel/HomepageMissionsCarousel.vue
@@ -4,7 +4,7 @@
     class="bg-star-pattern bg-black"
   >
     <section
-      class="HomepageMissionsCarousel ThemeVariantDark max-w-screen-3xl mx-auto overflow-hidden text-white bg-black bg-stars"
+      class="HomepageMissionsCarousel ThemeVariantDark max-w-screen-3xl mx-auto overflow-hidden text-white bg-black bg-stars select-none"
     >
       <div class="lg:BaseGrid lg:py-24 pt-14 container flex flex-col pb-5 mx-auto">
         <div class="xl:px-0 lg:col-end-8 xl:col-end-7 order-1 col-start-2 px-4">

From d8a5f056b2515b9af89ac73eb0d7f9f321adf783 Mon Sep 17 00:00:00 2001
From: James Ray <james.a.ray@jpl.nasa.gov>
Date: Mon, 9 Sep 2024 06:42:33 -0700
Subject: [PATCH 3/6] quick fix for shareButtons on curated galleries

---
 .../www/PageCuratedGallery/PageCuratedGallery.vue         | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/packages/vue/src/templates/www/PageCuratedGallery/PageCuratedGallery.vue b/packages/vue/src/templates/www/PageCuratedGallery/PageCuratedGallery.vue
index 991c691a..526ed5f6 100644
--- a/packages/vue/src/templates/www/PageCuratedGallery/PageCuratedGallery.vue
+++ b/packages/vue/src/templates/www/PageCuratedGallery/PageCuratedGallery.vue
@@ -265,6 +265,14 @@ export default defineComponent({
 
 <style lang="scss">
 .PageCuratedGallery {
+  // sharebuttons fix TODO: make better
+  @screen lg {
+    .ShareButtons {
+      transform: scale(0.75);
+      top: -1.8rem;
+      z-index: 999;
+    }
+  }
   .CuratedGallery-thumbnails,
   .CuratedGallery-carousel {
     @apply block;

From 4f441c52f656751ca3ab0c0b4cc7af6daa88e791 Mon Sep 17 00:00:00 2001
From: James Ray <james.a.ray@jpl.nasa.gov>
Date: Mon, 9 Sep 2024 06:43:04 -0700
Subject: [PATCH 4/6] fixes missioncarousel and featured robots on history
 navigation

---
 .../www/PageHomepage/PageHomepage.vue         | 24 +++++++++++--------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue b/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue
index cf861e71..98ddeb5b 100755
--- a/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue
+++ b/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue
@@ -107,18 +107,22 @@ export default defineComponent({
     </template>
 
     <!-- mission carousel -->
-    <HomepageMissionsCarousel
-      v-if="data?.missionsCarousel[0]?.targets?.length"
-      :data="data.missionsCarousel[0]"
-      class="lg:my-18 my-10"
-    />
+    <template v-if="data?.missionsCarousel">
+      <HomepageMissionsCarousel
+        v-if="data?.missionsCarousel[0]?.targets?.length"
+        :data="data.missionsCarousel[0]"
+        class="lg:my-18 my-10"
+      />
+    </template>
 
     <!-- featured robot -->
-    <HomepageFeaturedRobot
-      v-if="data?.featuredRobots?.length"
-      class="lg:my-24 my-12"
-      :data="data.featuredRobots[0].page"
-    />
+    <template v-if="data?.featuredRobots">
+      <HomepageFeaturedRobot
+        v-if="data?.featuredRobots?.length"
+        class="lg:my-24 my-12"
+        :data="data.featuredRobots[0].page"
+      />
+    </template>
 
     <!-- engage -->
     <div

From a501de37ab1b536c404bb22e0b0a5e0a41e255bc Mon Sep 17 00:00:00 2001
From: James Ray <james.a.ray@jpl.nasa.gov>
Date: Mon, 9 Sep 2024 06:55:46 -0700
Subject: [PATCH 5/6] fix link on pageImageDetail

---
 .../vue/src/templates/PageImageDetail/PageImageDetail.vue    | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/packages/vue/src/templates/PageImageDetail/PageImageDetail.vue b/packages/vue/src/templates/PageImageDetail/PageImageDetail.vue
index 2fe121b3..390fc02a 100755
--- a/packages/vue/src/templates/PageImageDetail/PageImageDetail.vue
+++ b/packages/vue/src/templates/PageImageDetail/PageImageDetail.vue
@@ -159,10 +159,7 @@
                 <BaseLink
                   variant="none"
                   link-class="font-primary text-jpl-red hover:text-jpl-red-light w-full py-3 text-lg"
-                  :to="{
-                    name: 'missions',
-                    query: { mission_target: item.target }
-                  }"
+                  to="/missions/?mission_target={{ item.target }}"
                 >
                   {{ item.target }}
                 </BaseLink>

From 76118c192e4f00cbcc9db6806d4066df09062aa9 Mon Sep 17 00:00:00 2001
From: Stephanie Smith <stephanie.c.smith@jpl.nasa.gov>
Date: Mon, 9 Sep 2024 08:25:31 -0700
Subject: [PATCH 6/6] implementing my code suggestions from review

---
 .../vue/src/templates/www/PageHomepage/PageHomepage.vue     | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue b/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue
index 98ddeb5b..34a0e4d2 100755
--- a/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue
+++ b/packages/vue/src/templates/www/PageHomepage/PageHomepage.vue
@@ -107,18 +107,16 @@ export default defineComponent({
     </template>
 
     <!-- mission carousel -->
-    <template v-if="data?.missionsCarousel">
+    <template v-if="data?.missionsCarousel && data?.missionsCarousel[0]?.targets?.length">
       <HomepageMissionsCarousel
-        v-if="data?.missionsCarousel[0]?.targets?.length"
         :data="data.missionsCarousel[0]"
         class="lg:my-18 my-10"
       />
     </template>
 
     <!-- featured robot -->
-    <template v-if="data?.featuredRobots">
+    <template v-if="data?.featuredRobots?.length">
       <HomepageFeaturedRobot
-        v-if="data?.featuredRobots?.length"
         class="lg:my-24 my-12"
         :data="data.featuredRobots[0].page"
       />