Harmony 1929 - Ensure OPeNDAP downloads use POST #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1929
Description
Since opendap can have potentially very long data download URLs we need to ensure that we convert the query string to POST body parameters in those cases and submit a POST request.
NOTE: I did see OPeNDAP timing out for very long URLs.
The snyk check is failing due to an internal snyk error.
Local Test Steps
This is how I tested:
https://opendap.uat.earthdata.nasa.gov/collections/C1261703111-EEDTEST/granules/SC:ATL03.006:264549068.dap.nc4?dap4.ce=/ds_surf_type[0:1:4]
pip install -e ./path/to/harmony_py
).env=Environment.LOCAL
and make a download request (e.g.harmony_client.download_all('88aebf3b-bb47-475d-8d54-05fa9812ae77', overwrite=True)
).PR Acceptance Checklist