Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched SemanticVersion #128

Open
mosesprime opened this issue Dec 21, 2024 · 0 comments
Open

Mismatched SemanticVersion #128

mosesprime opened this issue Dec 21, 2024 · 0 comments

Comments

@mosesprime
Copy link

There seems to be a mismatch in the lua 5.4 versioning between the build and the zon.

ziglua/build/lua.zig

Lines 16 to 37 in 90dab7e

const version = switch (lang) {
.lua51 => std.SemanticVersion{ .major = 5, .minor = 1, .patch = 5 },
.lua52 => std.SemanticVersion{ .major = 5, .minor = 2, .patch = 4 },
.lua53 => std.SemanticVersion{ .major = 5, .minor = 3, .patch = 6 },
.lua54 => std.SemanticVersion{ .major = 5, .minor = 4, .patch = 6 },
else => unreachable,
};
const lib = if (shared)
b.addSharedLibrary(.{
.name = "lua",
.target = target,
.optimize = optimize,
.version = version,
})
else
b.addStaticLibrary(.{
.name = "lua",
.target = target,
.optimize = optimize,
.version = version,
});

vs

ziglua/build.zig.zon

Lines 26 to 29 in 90dab7e

.lua54 = .{
.url = "https://www.lua.org/ftp/lua-5.4.7.tar.gz",
.hash = "12206df90729936e110f5d2574437be370fc4367b5f44afcc77749ac421547bc8ff0",
},

I am still new to zig, so please forgive my naivete, but is defining the semantic version in build/lua.zig strictly necessary if the version is already controlled by build.zig.zon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant