Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ziglua build broken on zig 0.14.0-dev.2596+e6879e99e #130

Open
nurpax opened this issue Jan 3, 2025 · 0 comments
Open

Ziglua build broken on zig 0.14.0-dev.2596+e6879e99e #130

nurpax opened this issue Jan 3, 2025 · 0 comments

Comments

@nurpax
Copy link
Contributor

nurpax commented Jan 3, 2025 

C:\Users\janne\dev\ziglua>zig build
C:\Users\janne\dev\ziglua\build\luajit.zig:166:8: error: no field or member function named 'defineCMacro' in 'Build.Step.Compile'
    lib.defineCMacro("LUAJIT_UNWIND_EXTERNAL", null);
    ~~~^~~~~~~~~~~~~
C:\Users\janne\scoop\apps\zig-dev\0.14.0-dev.2596\lib\std\Build\Step\Compile.zig:1:1: note: struct declared here
const builtin = @import("builtin");
^~~~~
C:\Users\janne\dev\ziglua\build\luajit.zig:166:8: note: method invocation only supports up to one level of implicit pointer dereferencing
C:\Users\janne\dev\ziglua\build\luajit.zig:166:8: note: use '.*' to dereference pointer
referenced by:
    build: C:\Users\janne\dev\ziglua\build.zig:45:42
    runBuild__anon_4629: C:\Users\janne\scoop\apps\zig-dev\0.14.0-dev.2596\lib\std\Build.zig:2388:33
    5 reference(s) hidden; use '-freference-trace=7' to see all references

FWIW, it was still fine very recently on zig 0.14.0-dev.2384.
nurpax added a commit to nurpax/ziglua that referenced this issue Jan 3, 2025
@nurpax
Fix build break for zig 0.14.0-dev.2596
64f7e18 
- There's no root_module.addCMacro anymore

- There's also no root_module.unwind_tables boolean anymore.  My fix only
  fixes the break but I don't know what's the right value to set here.  The
  choices are null, sync, and async.  I couldn't get the luajit variant
  to build on Windows.

for natecraddock#130
nurpax added a commit to nurpax/ziglua that referenced this issue Jan 3, 2025
@nurpax
Fix build break for zig 0.14.0-dev.2596
2233e8f 
- There's no root_module.addCMacro anymore

- There's also no root_module.unwind_tables boolean anymore.  My fix only
  fixes the break but I don't know what's the right value to set here.  The
  choices are null, sync, and async.  I couldn't get the luajit variant
  to build on Windows.

for natecraddock#130
@nurpax nurpax mentioned this issue Jan 3, 2025
Merged
nurpax added a commit to nurpax/ziglua that referenced this issue Jan 6, 2025
@nurpax
Fix build break for zig 0.14.0-dev.2596
3d36e37 
- There's no root_module.addCMacro anymore

- There's also no root_module.unwind_tables boolean anymore.  Setting
  "unwind_tables = .sync" should match earlier behavior.

for natecraddock#130
nurpax added a commit to nurpax/ziglua that referenced this issue Jan 24, 2025
@nurpax
update ziglua to work with 0.14.0-dev.2851+b074fb7dd
d8bce37 
+ this includes fixing things to enable running "zig build test"

for natecraddock#130
natecraddock pushed a commit that referenced this issue Jan 24, 2025
@nurpax @natecraddock
Fix build break for zig 0.14.0-dev.2596
c8ef55d 
- There's no root_module.addCMacro anymore

- There's also no root_module.unwind_tables boolean anymore.  Setting
  "unwind_tables = .sync" should match earlier behavior.

for #130
natecraddock pushed a commit that referenced this issue Jan 24, 2025
@nurpax @natecraddock
update ziglua to work with 0.14.0-dev.2851+b074fb7dd
8e2ec2f 
+ this includes fixing things to enable running "zig build test"

for #130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nurpax