This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
forked from cronie-crond/cronie
-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog
2194 lines (1367 loc) · 81.3 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2016-06-23 Tomas Mraz <tmraz@fedoraproject.org>
* Remove unneeded obsolete SELinux includes.
2016-06-23 Tomas Mraz <tmraz@fedoraproject.org>
* Rename timeval time to tv so time function can be used.
2016-06-23 Tomas Mraz <tmraz@fedoraproject.org>
* Fix longstanding race condition on crontab modification.
If crontab is modified twice at the same second the crond reads it
which means the timestamp will not change, the latest content will
never be read.
2016-06-10 Tomas Mraz <tmraz@fedoraproject.org>
* Fix misleading comment in pam configuration file.
2016-05-13 Tomas Mraz <tmraz@fedoraproject.org>
* anacron: use mkstemp() instead of tempnam()
Although the use of tempnam() seemed to be safeguarded
better to not use it at all.
2016-05-13 Tomas Mraz <tmraz@fedoraproject.org>
* anacron: Drop potentially unsafe umask setting.
2016-05-13 Tomas Mraz <tmraz@fedoraproject.org>
* anacron: Do not try to mail to empty address.
2016-04-25 Tomas Mraz <tmraz@fedoraproject.org>
* Clarify the crontab(1) documentation.
2016-04-23 Gary Tierney <gary.tierney@gmx.com>
* Remove hardcoded "system_u" SELinux user
This gets rid of the hardcoded reference to the ref-policy system_u user
and instead relies on the user that cronie is currently running as.
2016-04-25 Tomas Mraz <tmraz@fedoraproject.org>
* Clarify return value.
2016-03-15 Tomas Mraz <tmraz@fedoraproject.org>
* Correct instructions for disabling Anacron.
2015-11-07 Ville Skyttä <ville.skytta@iki.fi>
* Man page syntax fixes
2015-11-05 Robert Byrnes <Robert.Byrnes@deshaw.com>
* Inherit PATH from the crond environment if -P option is used.
2015-07-13 Tomas Mraz <tmraz@fedoraproject.org>
* In crontab command use a temporary filename that is ignored by crond.
2015-05-28 Tomas Mraz <tmraz@fedoraproject.org>
* Add *.patch and *.orig to .gitignore
2015-05-28 Tomas Mraz <tmraz@fedoraproject.org>
* Add compile to .gitignore.
2015-05-28 Tomas Mraz <tmraz@fedoraproject.org>
* Release new version 1.5.0
properly create dist tarball even with anacron and PAM disabled
2015-05-28 Tomas Mraz <tmraz@fedoraproject.org>
* Pass the job environment also when executing the sendmail.
2015-01-31 Felix Janda <felix.janda@posteo.de>
* database.c: Use POSIX NAME_MAX instead of BSD MAXNAMLEN
2015-04-21 Tomas Mraz <tmraz@fedoraproject.org>
* Prevent adding duplicate orphans on reload.
2015-02-05 Tomas Mraz <tmraz@fedoraproject.org>
* Do not overwrite the last zero-byte.
2015-02-03 Tomas Mraz <tmraz@fedoraproject.org>
* Log the crond shutdown.
2015-01-28 Tomas Mraz <tmraz@fedoraproject.org>
* No need to call strcmp on already matched variables.
2015-01-28 Tomas Mraz <tmraz@fedoraproject.org>
* Use unbiased random number for RANDOM_DELAY.
2015-01-28 Tomas Mraz <tmraz@fedoraproject.org>
* Call PAM only when it makes sense.
2015-01-28 Tomas Mraz <tmraz@fedoraproject.org>
* Fix broken test for match_rx() failure.
2014-11-04 Tomas Mraz <tmraz@fedoraproject.org>
* Properly check the existence of the user at the time the job is run.
2014-09-17 Marcela Mašláňová <mmaslano@redhat.com>
* contrib/cronie.systemd: Services must be running before starting
crond, otherwise many jobs is not running properly for no obvious
reason. nss-user-lookup.target should help when people are authenticated
through nss/sssd. Based on: https://bugzilla.redhat.com/show_bug.cgi?id=1067236
2014-07-30 Marcela Mašláňová <mmaslano@redhat.com>
* src/cron.c: More logging when getpwnam fails. Based on: rhbz#1123984 Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2014-07-25 Marcela Mašláňová <mmaslano@redhat.com>
* configure.ac, src/env.c: BSD doesn't define environ in unistd.h.
Also cronie didn't have option for enabling BSD specifics. Based on: naota@gentoo.org Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2014-07-25 Marcela Mašláňová <mmaslano@redhat.com>
* anacron/readtab.c: Add missing brackets into anacron readtab. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2014-07-25 Marcela Mašláňová <mmaslano@redhat.com>
* src/misc.c: Include missing header for signal handlers. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2014-07-04 Marcela Mašláňová <mmaslano@redhat.com>
* contrib/cronie.systemd: Missing reload definition in unit file was
added. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2014-04-30 Marcela Mašláňová <mmaslano@redhat.com>
* : commit b2c8cbcef8c97b5a175d6e71995249b288707b0f Author: Tomas
Mraz <tmraz@fedoraproject.org> Date: Tue Apr 29 14:08:25 2014
+0200
2014-03-31 Martin Poole <mpoole@redhat.com>
* src/misc.c: crond installs a signal hander for SIGINT & SIGTERM
which removes the pid file and exits. This handler is not reset for
individual forked sub-processes which results in the condition that
if the child receives SIGINT or SIGTERM the pid file is erroneously
removed. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2014-02-14 Marcela Mašláňová <mmaslano@redhat.com>
* anacron/readtab.c: Anacron does not correctly check configuration
parameters for validity and can segfault on certain data types. The return code
from the match_rx calls in readtab.c are not being checked
correctly. Bugfix let to segfaults in downstreams on non intel
architectures. All options in anacrontab should be now working
correctly. Based on patch from: Martin Poole
2014-01-20 Marcela Mašláňová <mmaslano@redhat.com>
* contrib/cronie.systemd: Remove syslog.target according to Fedora
and systemd guidelines. https://fedorahosted.org/fpc/ticket/177#comment:2 Thanks to: Ville Skyttä
2014-01-17 Ville Skyttä <ville.skytta@iki.fi>
* man/anacron.8: [PATCH] Fix anacron.8 UTF-8 encoding. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2013-12-18 Ville Skyta <ville.skytta@iki.fi>
* anacron/lock.c, anacron/readtab.c, man/crontab.5, src/cron.c,
src/database.c: Spelling fixes. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2013-12-18 Ville Skytta <ville.skytta@iki.fi>
* anacron/readtab.c, src/do_command.c: strncmp() size fixes. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2013-12-18 Martin Poole <mpoole@redhat.com>
* anacron/readtab.c: Anacron does not correctly check configuration
parameters for validity and can segfault on certain data types. The
return code from the match_rx calls in readtab.c are not being
checked correctly. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2013-09-26 Marcela Mašláňová <mmaslano@redhat.com>
* man/cron.8: crond -n must change pam setting.
2013-09-12 Marcela Mašláňová <mmaslano@redhat.com>
* cronie.init: Non-root user can't read configuration. Init file
will fail with proper error message. rhbz#1006869
2013-08-29 Marcela Mašláňová <mmaslano@redhat.com>
* : commit 2ec335f9549e8134102ac37665171a40a5407512 Author: Saul
Wold <sgw@linux.intel.com> Date: Mon Aug 26 11:18:27 2013 +0200
2013-08-16 Tomas Mraz <tmraz@fedoraproject.org>
* src/security.c: Pull PAM environment variables also from session
modules. - also fix memory leak of environment returned by pam_getenvlist()
2013-08-13 Marcela Mašláňová <mmaslano@redhat.com>
* contrib/cronie.systemd: KillMode in systemd unit file will enable
to finish jobs executed by cron. Even if cron dies, jobs should
continue. Based on: https://bugzilla.redhat.com/show_bug.cgi?id=919290
2013-08-09 Tomas Mraz <tmraz@fedoraproject.org>
* src/misc.c: Fcntl locking has different semantics than flock.
Prefer flock.
2013-07-18 Marcela Mašláňová <mmaslano@redhat.com>
* ChangeLog, configure.ac: Release 1.4.11
2013-06-11 Tomas Mraz <tmraz@fedoraproject.org>
* src/user.c: Log failures in load_user().
2013-06-11 Tomas Mraz <tmraz@fedoraproject.org>
* man/crontab.5, src/cron.c, src/entry.c, src/env.c, src/globals.h,
src/structs.h: Add support for RANDOM_DELAY of jobs.
2013-06-11 Tomas Mraz <tmraz@fedoraproject.org>
* src/user.c: Fixed bug introduced by previous commit and simplified
error handling.
2013-06-07 Tomas Mraz <tmraz@fedoraproject.org>
* src/env.c, src/funcs.h, src/user.c: Copy some variables from the
crond process environment. Also cleanup error handling in load_env().
2013-06-06 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c: setenv takes 3 arguments
2013-06-06 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c: Do not use putenv with string literal.
2013-04-25 Tomas Mraz <tmraz@fedoraproject.org>
* src/do_command.c: Make From field in mails from crond RFC
compliant.
2012-12-30 Sami Kerola <kerolasa@iki.fi>
* src/crontab.c: cron: clarify usage() print out The -n option needs argument, which was missing from the usage(). Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-12-29 Sami Kerola <kerolasa@iki.fi>
* anacron/global.h, anacron/main.c, anacron/readtab.c: anacron: fix
shadow declarations Change global variables to have more specific name. This will make
warnings about shadowing to go away, and may result to a little more
readable code. log.c:74:35: warning: declaration of 'args' shadows a global
declaration [-Wshadow] global.h:97:15: warning: shadowed declaration
is here [-Wshadow] Reference:
http://web.archiveorange.com/archive/v/N6p0RpcfZsIBsaU8B2sE#72jDywyk8NZ3i9gSigned-off-by: Sami Kerola <kerolasa@iki.fi>
2012-12-29 Sami Kerola <kerolasa@iki.fi>
* src/crontab.c, src/entry.c, src/macros.h, src/security.c: smatch
scan: fix various warningss found using smatch entry.c:396 load_entry() info: redundant null check on e->pwd
calling free() entry.c:398 load_entry() info: redundant null check
on e->cmd calling free() /usr/include/bits/fcntl.h:48:10: warning: preprocessor token
O_NOFOLLOW redefined macros.h:136:9: this was the original
definition security.c:98:44: warning: non-ANSI function declaration of function
'cron_restore_default_security_context' crontab.c:439:29: warning:
non-ANSI function declaration of function 'tmp_path' Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2013-01-02 Marcela Mašláňová <mmaslano@redhat.com>
* man/cron.8: Mention systemctl command in man page of crond. Based
on rhbz#891160.
2012-12-20 Sami Kerola <kerolasa@iki.fi>
* contrib/0anacron: contrib: remove bashisms Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-12-20 Sami Kerola <kerolasa@iki.fi>
* COPYING.anacron, anacron/global.h, anacron/gregor.c,
anacron/gregor.h, anacron/lock.c, anacron/log.c, anacron/main.c,
anacron/matchrx.c, anacron/matchrx.h, anacron/readtab.c,
anacron/runjob.c: docs: corrections to FSF license files, and postal
address The COPYING and file is replaced by files from GNU web site. http://www.gnu.org/licenses/gpl-2.0.txt Postal addresses to FSF in other files are updated to match with the
address in license files. References:
http://lists.gnu.org/archive/html/freefont-announce/2005-04/msg00001.htmlSigned-off-by: Sami Kerola <kerolasa@iki.fi>
2012-12-02 Sami Kerola <kerolasa@iki.fi>
* cronie.init: init script: remove bashisms References: https://sourceforge.net/projects/checkbaskisms/
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-12-01 Sami Kerola <kerolasa@iki.fi>
* anacron/log.c, anacron/main.c, anacron/readtab.c,
anacron/runjob.c: anacron: make function declarations to be ansi
compliant Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-12-01 Sami Kerola <kerolasa@iki.fi>
* anacron/main.c, anacron/runjob.c: anacron: remove numeric exit and
file descriptor values Use symbolic values from standard header instead. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-12-01 Sami Kerola <kerolasa@iki.fi>
* anacron/main.c: anacron: clean up usage() output Inform in usage which options will need arguments, and add reference
to manual page. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-12-01 Sami Kerola <kerolasa@iki.fi>
* anacron/runjob.c: anacron: set end job message string to be
constant runjob.c:308:7: warning: assignment discards 'const' qualifier from
pointer target type [enabled by default] Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-12-01 Sami Kerola <kerolasa@iki.fi>
* anacron/global.h, anacron/main.c: anacron: add function attributes Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-12-01 Sami Kerola <kerolasa@iki.fi>
* Makefile.am, cronie_common.h, src/cron.c, src/crontab.c,
src/security.c: compile: add function attributes Some of the argument values are not in use, and few functions does
not return. Informing which will make few warning messages
disapper, and compiler to generate better binary. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-12-01 Sami Kerola <kerolasa@iki.fi>
* src/cron.c: compile: fix signed and unsigned warnings cron.c:100:16: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare] cron.c:108:16: warning:
comparison between signed and unsigned integer expressions
[-Wsign-compare] cron.c:125:16: warning: comparison between signed
and unsigned integer expressions [-Wsign-compare] Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-27 Sami Kerola <kerolasa@iki.fi>
* src/cron.c: crond: make usage easier to read Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-27 Sami Kerola <kerolasa@iki.fi>
* src/crontab.c: crontab: make usage easier to read Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-27 Marcela Mašláňová <mmaslano@redhat.com>
* ChangeLog, configure.ac: New release 1.4.10.
2012-11-27 Marcela Mašláňová <mmaslano@redhat.com>
* src/crontab.c, src/do_command.c, src/funcs.h: Condtionalize pam
functions.
2012-11-27 Tomas Mraz <tmraz@fedoraproject.org>
* configure.ac: Drop duplicate -lselinux -laudit.
2012-11-27 Tomas Mraz <tmraz@fedoraproject.org>
* src/funcs.h, src/security.c, src/structs.h: Fix missing includes
for selinux and other types.
2012-11-27 Marcela Mašláňová <mmaslano@redhat.com>
* man/cron.8, src/cron.c: Fix some issues introduced in c58b1d9
Documentation improvements based on Michael Lass suggestions. * give -m an own line in manpage * don't explain -P twice * correct description of -P to what it actually does Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2012-11-26 Tomas Mraz <tmraz@fedoraproject.org>
* src/crontab.c: Fix const usage in crontab.
2012-11-22 Sami Kerola <kerolasa@iki.fi>
* man/anacron.8: docs: anacron fix out dated information about open
file limits For quite a while open files limit has defaulted to 1024, but rather
than informing what might be the number user should inspect value
from own time. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-22 Sami Kerola <kerolasa@iki.fi>
* man/anacrontab.5: docs: fix reference to other manual There is no crontabs(4). For user it makes most sense to look
crontab(1). Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-22 Sami Kerola <kerolasa@iki.fi>
* man/anacron.8, man/anacrontab.5, man/cron.8, man/crontab.1,
man/crontab.5: docs: fix various groff issues * Add spaces after dots (English spacing). * Remove use of inline emphasis where possible. * Use mail and url macros. * Wrap long and join short lines. * Remove end of line white spaces. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* configure.ac, src/pathnames.h: build-sys: make ./configure to
seach vi path Using "/usr/ucb/vi" as defaut fallback EDITOR is not going to work
on most of distributions where this package is installed. That said
it might work somewhere, so searching the vi editor at configure
time is the sensible thing to do, if user does not want to define
the default. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* src/cron.c, src/crontab.c, src/database.c, src/do_command.c,
src/entry.c, src/env.c, src/macros.h, src/security.c, src/user.c:
debuging: make Debug macro look like function This will make indent(1) program not to think it is a clause. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* src/do_command.c, src/user.c: declarations: fix shadow
declarations user.c:68:7: warning: declaration of 'save_errno' shadows a previous
local [-Wshadow] user.c:64:14: warning: shadowed declaration is here
[-Wshadow] do_command.c:559:9: warning: declaration of 'pid' shadows a previous
local [-Wshadow] do_command.c:91:8: warning: shadowed declaration is
here [-Wshadow] Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* src/Makefile.am, src/cron.c, src/cron.h, src/crontab.c,
src/database.c, src/do_command.c, src/entry.c, src/env.c,
src/externs.h, src/funcs.h, src/globals.h, src/job.c, src/macros.h,
src/misc.c, src/popen.c, src/pw_dup.c, src/security.c,
src/structs.h, src/user.c: includes: make inclusions clean This change makes files to include what they need, instead of having
generic inclusion headers which will include everything to
everywhere. Also the local headers havee ifndef & define
protection, which makes them to be save to include in any file,
without one having to think in which order the inclusions happen at
compile time. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-26 Tomas Mraz <tmraz@fedoraproject.org>
* src/misc.c: Fix up also the const in comment.
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* src/crontab.c, src/database.c, src/env.c, src/funcs.h, src/misc.c:
variables: use const where ever possible Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* src/crontab.c, src/security.c, src/user.c: build-sys: reduce
selinux and pam compiling scope when possible This will fix following warnings, and makes compiled program to
contain less unnecessary references. crontab.c:60:14: warning: 'selinux_context' defined but not used
[-Wunused-variable] security.c:188:12: warning:
'cron_open_pam_session' defined but not used [-Wunused-function]
security.c:250:12: warning: 'cron_authorize_context' defined but not
used [-Wunused-function] security.c:283:12: warning:
'cron_authorize_range' defined but not used [-Wunused-function] Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* src/crontab.c: compliancy: do not mix declarations and code Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* src/database.c, src/do_command.c: clean up: reduce variable
passing when they are not used Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* src/database.c, src/pw_dup.c, src/security.c: assingments: remove
initialization if value is never used The next operation with these variables will overwrite the values
set at init. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* src/cron.c, src/entry.c, src/env.c, src/misc.c, src/popen.c:
compliancy: use memset() rather than bzero() Reference:
http://pubs.opengroup.org/onlinepubs/9699919799/xrat/V4_xsh_chap03.htmlSigned-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* src/Makefile.am: build-sys: make clean needs to remove
cron-paths.h The file is generated at build time. This change is needed to make
distcheck work without an error. [...] ERROR: files left in build directory after distclean:
./src/cron-paths.h Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-24 Sami Kerola <kerolasa@iki.fi>
* autogen.sh: build-sys: add autotools helper script The script will help building when source code is checked out from
git. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2012-11-26 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c: Do not log that syslog will be used instead of
sendmail if explicitly requested.
2012-11-26 Tomas Mraz <tmraz@fedoraproject.org>
* configure.ac, src/cron.c, src/database.c: Enable system crontab by
default and use AC_ARG_ENABLE instead of AC_ARG_WITH.
2012-11-22 Marcela Mašláňová <mmaslano@redhat.com>
* ChangeLog, configure.ac: Minor release 1.4.9.
2012-11-13 Marcela Mašláňová <mmaslano@redhat.com>
* man/cron.8, src/cron.c: Documentation improvements based on
Michael Lass suggestions.
2012-11-02 Marcela Mašláňová <mmaslano@redhat.com>
* contrib/cronie.systemd: Add time-sync.target. If synchronization
is used, crond will start after sync by ntpd/chrony. rhbz#872516
2012-10-11 Tom Jones <tom@oxix.org>
* man/cron.8, src/cron.c, src/entry.c, src/globals.h: The sysadmin
may want to arrange for the PATH to be correct in the environment
from which cron is launched. This new option tells cron to not
overwrite this path for itself or for the child cron jobs. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2012-07-24 Marcela Mašláňová <mmaslano@redhat.com>
* configure.ac: The enable-relro erased previously set LDFLAGS.
2012-07-02 Marcela Mašláňová <mmaslano@redhat.com>
* man/crontab.5: Fix typo in man page. rhbz#836292 Thanks to: Dave Allan
2012-06-22 Marcela Mašláňová <mmaslano@redhat.com>
* anacron/global.h, anacron/lock.c, anacron/main.c,
anacron/readtab.c: Preferred hour of start of the job. If the hour
is missed job will be skipped.
2012-06-21 Marcela Mašláňová <mmaslano@redhat.com>
* anacron/readtab.c: Range of hours for daily jobs must have
lower-higher hour.
2012-06-21 Marcela Mašláňová <mmaslano@redhat.com>
* src/crontab.c: Crontab has wrong permission. Based on rhbz#676081
2012-06-19 Marcela Mašláňová <mmaslano@redhat.com>
* configure.ac, src/cron.c, src/database.c: syscrontab, the system
crontab, is not mandatory anymore. Cronie can be build without it. The patch was based on complaints of
distribution without /etc/crontab file. https://fedorahosted.org/cronie/ticket/10
2012-06-13 Marcela Mašláňová <mmaslano@redhat.com>
* src/cron.c, src/do_command.c: Sendmail doesn't have to be
installed. The info message should make sense. https://fedorahosted.org/cronie/ticket/15
2012-06-06 Tim Landscheidt <tim@tim-landscheidt.de>
* src/cron.c: Previously, crond exited in the signal handler for
SIGINT and SIGTERM. Thus, the Inotify close code in main() was
never reached. This commit introduces a got_sigintterm variable
that is set when SIGINT or SIGTERM are received and leads to a clean
exit of the main loop. * src/cron.c: Rename quit() to sigintterm_handler(). Add
got_sigintterm variable and set it on SIGINT and SIGTERM. Shorten
sleep and exit main loop on got_sigintterm. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2012-06-06 Tim Landscheidt <tim@tim-landscheidt.de>
* src/entry.c: 9th bit is overwritten. Hour bit fields have 24 bits (0..23, 3 bytes). bit_nclear() however
in this case is called to clear bits 0..24! Thus, it overwrites the
first bit of the following struct member (dom). This is not
problematic for normal use as dom is set after hour as are all other
fields. The last field, dow, uses 8 bits so 9 are cleared. This could be the
MIN_STAR bit of flags, but as flags is an int, there is probably a
padding byte in between; at least I couldn't trigger it to be unset.
So this could probably only cause problems on 8-bit systems. https://fedorahosted.org/cronie/ticket/11 Signed-off-by: Marcela
Mašláňová <mmaslano@redhat.com>
2012-06-06 Tim Landscheidt <tim@tim-landscheidt.de>
* anacron/readtab.c, anacron/runjob.c: Remove unused variables. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2012-06-06 Tim Landscheidt <tim@tim-landscheidt.de>
* anacron/runjob.c: Fix use of "const char *" in call to putenv(). Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2012-04-12 Marcela Mašláňová <mmaslano@redhat.com>
* src/do_command.c: The mail header for automatic reply will now
contain another field: "Precedence: bulk", which is not compulsory
according to RFC3834. Based on: Harald Reindl request in rhbz#811186
2012-04-12 Sven Vermeulen <swift@gentoo.org>
* src/security.c: setkeycreatecon is not needed. Users should
inherited key context if it was already set for them. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2012-04-11 Marcela Mašláňová <mmaslano@redhat.com>
* Makefile.am, contrib/cronie.systemd: systemd unit file was added
into contrib This unit file is used in Fedora. The systemd-user-sessions.service
guarantees everything, what is needed for log in of users, is
already running (ypbind, sssd, ldap, ...).
2012-04-11 T.M. Abraham <tabraham@novell.com>
* man/crontab.5: adjust documentation title to reference "crontab"
instead of "anacrontab" Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2011-12-07 Tomas Mraz <tmraz@fedoraproject.org>
* contrib/0anacron, contrib/0hourly, contrib/dailyjobs, man/cron.8,
man/crontab.5: Adjust the documentation to better describe the
current situation with crontab and anacrontab.
2011-11-24 Marcela Mašláňová <mmaslano@redhat.com>
* man/crontab.1: Add name of file, where can be set PAM
configuration.
2011-10-24 Petr Sabata <psabata@redhat.com>
* cronie.init: Service restart needlessly reports failure. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2011-10-06 Marcela Mašláňová <mmaslano@redhat.com>
* src/security.c: Raw context should be used. Especially when
mcstransd in older releases is running.
2011-09-20 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c, src/crontab.c: No need to have full path in the
ProgramName.
2011-06-29 Tomas Mraz <tmraz@fedoraproject.org>
* : commit 01a692b123c885c883e7791f0a1833df5edfe327 Author: Tomas
Mraz <tmraz@fedoraproject.org> Date: Wed Jun 29 12:42:27 2011
+0200
2011-06-29 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c: Revert "Cronie disables inotify support when the
/etc/crontab file does not exist at startup." This reverts commit acdf4ae8456888ed78201906ef528f4c28f54582 as it
introduces fd leaks.
2011-06-27 Marcela Mašláňová <mmaslano@redhat.com>
* ChangeLog, configure.ac: Minor release 1.4.8
2011-06-24 Marcela Mašláňová <mmaslano@redhat.com>
* src/do_command.c: Cron writes job output to syslog incorrectly.
When cron is invoked in a way to print job output to syslog, it does
print only the first character of the output. Author: Vitezslav
Cizek Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2011-06-21 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c, src/database.c, src/funcs.h, src/structs.h: Check
orphaned crontabs for adoption.
2011-06-21 Tomas Mraz <tmraz@fedoraproject.org>
* src/do_command.c: Unify logging in case of SyslogOutput with the
rest of crond.
2011-05-26 Marcela Mašláňová <mmaslano@redhat.com>
* man/cron.8, man/crontab.1: Change of email adress of cluster
support author.
2011-05-16 Kiyoshi OHGISHI <ohgishi@gaia.eonet.ne.jp>
* anacron/main.c: The charset of anacron's mail is always
ANSI_X3.4-1968. There are no setlocale is anacron's source. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2011-04-28 Marcela Mašláňová <mmaslano@redhat.com>
* src/cron.c: Cronie disables inotify support when the /etc/crontab
file does not exist at startup. Existence of crontab and directories wasn't controlled before
creating inotify watches.
2011-03-15 Marcela Mašláňová <mmaslano@redhat.com>
* configure.ac: Clean configure.
2011-03-15 Marcela Mašláňová <mmaslano@redhat.com>
* ChangeLog, configure.ac: New release 1.4.7.
2011-03-15 Marcela Mašláňová <mmaslano@redhat.com>
* configure.ac: Split relro and pie into two options.
2011-03-11 Tomas Mraz <tmraz@fedoraproject.org>
* anacron/matchrx.c: Add missing va_end() call.
2011-03-11 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c: Remove unused variable.
2011-03-11 Tomas Mraz <tmraz@fedoraproject.org>
* src/env.c: Fix incorrect pointer in sizeof.
2011-03-11 Tomas Mraz <tmraz@fedoraproject.org>
* src/crontab.c: Fixed leaking of env and members of entry in
replace_cmd().
2011-03-11 Tomas Mraz <tmraz@fedoraproject.org>
* src/database.c, src/user.c: Fix memory leaks in load_user.
2011-03-11 Tomas Mraz <tmraz@fedoraproject.org>
* src/entry.c: The last bit to set is always LAST_ - FIRST_.
2011-03-11 Tomas Mraz <tmraz@fedoraproject.org>
* anacron/matchrx.c: Check malloc return for NULL.
2011-03-11 Tomas Mraz <tmraz@fedoraproject.org>
* src/misc.c: Do not try to compile dead code.
2011-03-11 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c, src/crontab.c, src/funcs.h, src/misc.c: Rename
set_cron_cwd() to check_spool_dir() as we do not do any chdir
anymore.
2011-03-11 Tomas Mraz <tmraz@fedoraproject.org>
* src/misc.c: Add missing check for stat() return value.
2011-03-09 Tomas Mraz <tmraz@fedoraproject.org>
* anacron/main.c: Safeguard for system time changes. Otherwise
anacron might wait with the job running for a too long time.
2011-03-08 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c: Fix the non-default timezone support. Do not run jobs
multiple times on DST change.
2011-03-07 Tomas Mraz <tmraz@fedoraproject.org>
* src/do_command.c, src/security.c: Set mailfrom to the user
account, better PAM logging.
2011-03-07 Tomas Mraz <tmraz@fedoraproject.org>
* src/do_command.c, src/funcs.h, src/popen.c, src/security.c: Set
only groups in the process handling PAM calls. Keep uids at 0 so the
process is not killable by the user.
2011-03-02 Tomas Mraz <tmraz@fedoraproject.org>
* src/do_command.c: Whitespace cleanups.
2011-03-02 Tomas Mraz <tmraz@fedoraproject.org>
* src/do_command.c, src/popen.c: Fix SIGPIPE handling in
do_command() and popen. Ensure that PAM session is always closed.
2011-02-21 Marcela Mašláňová <mmaslano@redhat.com>
* src/do_command.c: Comment not freeing mailfrom - found during code
review.
2011-02-21 Marcela Mašláňová <mmaslano@redhat.com>
* src/security.c: Free security contexts.
2011-02-18 Marcela Mašláňová <mmaslano@redhat.com>
* src/crontab.c: mkstemp needs only 6 X's
2011-02-21 Marcela Mašláňová <mmaslano@redhat.com>
* anacron/runjob.c: fdin could be tested before initialization.
2011-02-17 Marcela Mašláňová <mmaslano@redhat.com>
* configure.ac: PIE and RELRO flags to be set We want all long running daemons to have PIE and RELRO flags set.
This is a missing security mechanism. Fixing this generally involves
adding -fPIE -DPIE to the CFLAGS, and -pie -Wl,-z,relro -Wl,-z,now
to the LDFLAGS. Expected results: PIE and partial RELRO at a
minimum.
2010-12-16 Tomas Mraz <tmraz@fedoraproject.org>
* src/security.c: Add translation for remaining hardcoded contexts
and av bits.
2010-12-16 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c, src/funcs.h, src/security.c: Revert "Cache the
security class and bit values and translate the remaining hardcoded
values." Caching cannot be done as the values can change on SELinux
policy update. This reverts commit b15f72976965d2ae1a1273558bf45be7de077b79.
2010-12-16 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c: Revert "Missing exit if cron_init_security() fails."
Caching cannot be done as the values can change on SELinux policy
update. This reverts commit ac70de36ec6c403c28291689701bd2567c565107.
2010-12-16 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c: Missing exit if cron_init_security() fails.
2010-12-15 Tomas Mraz <tmraz@fedoraproject.org>
* src/cron.c, src/funcs.h, src/security.c: Cache the security class
and bit values and translate the remaining hardcoded values.
2010-12-15 Tomas Mraz <tmraz@fedoraproject.org>
* src/security.c: Clean up unnecessary assignment.
2010-12-15 Dan Walsh <dwalsh@redhat.com>
* src/security.c: This patch causes cronie to ask kernel for
constant definition rather then using hard coded Also add info to syslog message to help diagnose problems. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2010-12-10 Tomas Mraz <tmraz@fedoraproject.org>
* anacron/global.h, anacron/lock.c, anacron/main.c: Do not lock jobs
that fall out of allowed range - rhbz#661966
2010-10-26 Marcela Mašláňová <mmaslano@redhat.com>
* man/crontab.1: Man - another typo
2010-10-26 Marcela Mašláňová <mmaslano@redhat.com>
* man/cron.8, man/crontab.1: Re-add missing option into man and fix
some typos. Thanks to Colin Dean.
2010-10-22 Marcela Mašláňová <mmaslano@redhat.com>
* ChangeLog, configure.ac: New release 1.4.6
2010-10-21 Martin Prpič <mprpic@redhat.com>
* man/anacron.8, man/anacrontab.5, man/cron.8, man/crontab.1,
man/crontab.5: Rewrite of man pages & correction. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2010-10-21 Marcela Mašláňová <mmaslano@redhat.com>
* man/bitstring.3: Remove useless man page. Thanks to Colin Dean.
2010-10-21 Marcela Mašláňová <mmaslano@redhat.com>
* src/cron.c: Apply previous patch correctly.
2010-10-20 Colin Dean <c.c.dean@durham.ac.uk>
* src/cron.c: Check clustering before un/watch function Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2010-10-13 Marcela Mašláňová <mmaslano@redhat.com>
* : commit 2d3a872e9c66d9550a5b3cc97fa78ff9d7708cce Author: Marcela
Mašláňová <mmaslano@redhat.com> Date: Fri Oct 8 12:17:15 2010
+0200
2010-10-07 Marcela Mašláňová <mmaslano@redhat.com>
* man/cron.8: man page typo: change to correct option
2010-10-06 Marcela Mašláňová <mmaslano@redhat.com>
* src/database.c: Remove cluster support from inotify_database check_inotify_database is called only when inotify is on, which is
not with cluster support.
2010-10-06 Colin Dean <c.c.dean@durham.ac.uk>
* man/crontab.1, src/crontab.c: The crontab command uses "-c" and
"-n" instead of "-h". Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2010-10-04 Marcela Mašláňová <mmaslano@redhat.com>
* src/crontab.c: Correct ifdef HAVE_FCHOWN Based on https://fedorahosted.org/cronie/ticket/7 Thanks to
crrodriguez
2010-10-04 Marcela Mašláňová <mmaslano@redhat.com>
* .gitignore, src/database.c: is_local set to zero
2010-10-04 Colin Dean <c.c.dean@durham.ac.uk>
* man/cron.8, man/crontab.1, src/Makefile.am, src/cron.c,
src/crontab.c, src/database.c, src/globals.h: cronie on cluster On issue we have is that although we've made our services very
resilient, by employing HA failover, load balancing and round robin
DNS, the one service that's difficult to do anything with is cron,
because it has traditionally been tied to a single machine. For instance, we have a cluster of 4 Fedora servers which our end
users use as timeshare systems, using round robin DNS, and if one of
the servers is down it doesn't really matter too much. We don't even
backup the servers, relying on NFS home directories and rebuilding
from scratch using kickstart + cfengine if a server fails and can't
be restarted. However, the users have scattered crontab files around the 4
servers, so that if the particular server a cron job is meant to run
on dies, the job doesn't run any more, and the crontab file may be
permanently lost. What we needed was a facility to allow crontabs in /var/spool/cron
on these 4 servers be NFS mounted from a single directory on our
NetApp filers (so giving us backups and snapshots), with any user
able to run "crontab -e" from any of the servers to manage a single
shared crontab, and for us in the IT Service to be able to set just
one of the 4 servers to run user crontab jobs at any time. However,
we needed to keep /etc/crontab and the files in /etc/cron.d/
specific to each individual server still, and keep crond running on
all 4 servers. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2010-08-30 Marcela Mašláňová <mmaslano@redhat.com>
* anacron/runjob.c: Typo in log message Based on Tom London report
https://bugzilla.redhat.com/show_bug.cgi?id=626947
2010-08-23 Marcela Mašláňová <mmaslano@redhat.com>
* anacron/main.c: Close leaking file descriptor anacron was leaking fd, which caused denial of jobs by selinux.
2010-08-02 Marcela Mašláňová <mmaslano@redhat.com>
* ChangeLog, configure.ac: New minor release 1.4.5.
2010-08-02 Marcela Mašláňová <mmaslano@redhat.com>
* cronie.init: OK value printed twice Fix based on 615107. There were too many OK's messages.
2010-07-21 Marcela Mašláňová <mmaslano@redhat.com>
* src/cron.c: Help and usage fix Option -h was added. Also details about options were added into
usage.
2010-07-21 Marcela Mašláňová <mmaslano@redhat.com>
* man/cron.8: man crond -i Document missing option.
2010-07-12 Marcela Mašláňová <mmaslano@redhat.com>
* man/cron.8, src/cron.c: Syslog output will be used instead of mail If sendmail isn't installed, syslog is used. This patch should also
solve problem with RPM requirements of sendmail (and which mail
should be installed by default). Based on: https://bugzilla.redhat.com/show_bug.cgi?id=472710#c42
2010-04-14 Marcela Mašláňová <mmaslano@redhat.com>
* src/entry.c: Remove the whole unused part.
2010-04-14 Marcela Mašláňová <mmaslano@redhat.com>
* src/entry.c: Remove 'dont log' part which probably never worked.
2010-04-14 Marcela Mašláňová <mmaslano@redhat.com>
* src/do_command.c, src/entry.c: Beautify error outputs.
2010-04-14 Michal Seben <mseben@suse.cz>
* man/crontab.5, src/entry.c: Option "-" don't log jobs as root If the uid of the owner is 0 (root), he can put a "-" as first
character of a crontab entry. This will prevent cron from writing a
syslog message about this command getting executed. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2010-04-14 Michal Seben <mseben@suse.cz>
* src/security.c: Correctly reported PAM errors cron_conv could be helpfull for debug purposes, when something bad
happens with pam e.g. : expired user password - without cron_conv
cronie doesn't report usefull info in syslog messages (it just
write no conversation function error to messages file),if you want
to do quick test of pam conversation function, you could set
PASS_MAX_DAYS and PASS_WARN_AGE in etc/login.defs , add new user and
for this user create cron rule (crontab -e) Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2010-03-25 Andrew Man-Hon Lau <amlau@alum.mit.edu>
* contrib/0anacron: 0anacron should check only readability. Signed-off-by: Marcela Mašláňová <mmaslano@redhat.com>
2010-03-23 Marcela Mašláňová <mmaslano@redhat.com>
* src/security.c: Revert previous change. The code which control the
input entry should be sufficient. Only "/" are removed from scripts.
2010-03-22 Marcela Mašláňová <mmaslano@redhat.com>
* contrib/0hourly, contrib/dailyjobs, src/security.c: In system
tables was hardcoded home directory to "/". This was changed to
switching to "/" only when home for user isn't defined. Based on rhbz#575419
2010-02-23 Marcela Mašláňová <mmaslano@redhat.com>
* man/crontab.5: Definition of system crontables.
2010-02-18 Marcela Mašláňová <mmaslano@redhat.com>