Two patches to scheduler #682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (.freeSlots cluster bad-slots) | ||
| (EvenScheduler/schedule-topologies-evenly (Topologies. {topology-id topology}) cluster)))) | ||
| (.freeSlots cluster bad-slots)) | ||
| (EvenScheduler/schedule-topologies-evenly (Topologies. {topology-id topology}) cluster))) |
There was a problem hiding this comment.
topology-id is declared in doseq, while you are referencing topology-id out of doseq
|
@herberteuler any update on this PR? |
|
The LinkedHashMap change has been in the branch for our testing cluster for a while, and it has fixed the unexpected rescheduling issue there. We are planning to incorporate it into our next installation on the production cluster. |
|
@herberteuler can you describe a case which have issues with current implementation, while is fixed by your patch? |
|
I'll make a new PR later, with more detailed descriptions. Sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two patches here:
default-schedule: invoking toschedule-topologies-evenlyshould only be done after freeing allbad-slotsfor topologies that needs re-scheduling.SchedulerAssignmentImplcurrently usesHashMap, which does not preserve entries order. This can cause unnecessary and unexpected re-scheduling when nimbus convertsexecutor->node+portbetween its internal Clojure maps andSchedulerAssignmentImpl's Java maps back and forth.