Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for authenticated proxies #30

Open
sheerun opened this issue Oct 21, 2019 · 2 comments
Open

Support for authenticated proxies #30

sheerun opened this issue Oct 21, 2019 · 2 comments

Comments

@sheerun
Copy link

sheerun commented Oct 21, 2019

From what I see this gem supports only proxies that don't require Authorization header to be set:

    def initialize(proxy_addr, proxy_port)
      timeout = ProxyFetcher.config.proxy_validation_timeout

      @http = HTTP.follow.via(proxy_addr, proxy_port.to_i).timeout(connect: timeout, read: timeout)
    end

it would be nice if there was such possibility

@nbulaj
Copy link
Owner

nbulaj commented Oct 21, 2019

Hi @sheerun, nice idea, would you like to propose a PR? I'm totally for it 👍

@nbulaj
Copy link
Owner

nbulaj commented May 12, 2020

Added here #37

Btw I don't know how we can reuse it in the Manager just because all the providers don't have such info. Only if you manually use ProxyValidator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants