[BUG] - Infracost CI and DO tests failing

[pavithraes]

Originally reported by @pmeier on Quansight Slack

@Adam-D-Lewis triggered some tests on @pmeier's PR through the comment and the infracost jobs on AWS and Azure both fail because no credentials can be retrieved. Since Adam should have all the permissions, we need to figure out why this fails?

Refs:

• https://github.com/nebari-dev/nebari/actions/runs/5038088999/jobs/9035348504?pr=1778
• https://github.com/nebari-dev/nebari/actions/runs/5038088999/jobs/9035348581?pr=1778

The DO provider tests failing as well: https://github.com/nebari-dev/nebari/actions/runs/5016789600/jobs/8994092014#step:11:424

[kcpevey]

I'm seeing the same thing on my PR #1665

[pmeier]

I need functioning CI for PRs like #1773 or #1778 since they are large scale refactorings.

[kcpevey]

I'm guessing its related to our recent changes to our credentials infra. @iameskild or @costrouc might know more?

[dharhas]

Is infracost useful?/is it worth keeping that integration? It was build in a hurry and I don't know how good it is.

[iameskild]

I believe DO is failing because the API token recently expired. I opened a PR last week that will enable me to make this update but I'm waiting for Chris to return from PTO.

As for Infracost, I personally don't think it's worth the maintenance burden of keeping integrated. As Dharhas said, it was hastily added so its utility at this moment is relatively limited. I propose we rip it out (along with Prefect and ClearML).

[pmeier]

As for Infracost, I personally don't think it's worth the maintenance burden of keeping integrated. As Dharhas said, it was hastily added so its utility at this moment is relatively limited.

Let me send a PR for that.

[pmeier]

@dharhas I talked to @iameskild offline and we interpreted your #1817 (comment) differently. Do you mean we should just kill the CI jobs or rip it out completely? Currently it is part of our CLI

nebari/nebari/cli/main.py

Line 385 in 4111625

def cost(

However, it is marked "experimental"

nebari/nebari/cli/main.py

Line 420 in 4111625

[italic]This is still only experimental using Infracost under the hood.

and thus we can likely purge it without BC concerns.

[dharhas]

I'm questioning whether the infracost integration is useful. It was integrated by an intern and I don't think we have ever used it. Before we spend time fixing the tests we should decide whether we want to keep the integration.

So I'm asking if we should rip it out completely from Nebari.

[pmeier]

There is #1820 to remove the infracost capabilities. Re-labeling as needs: investigation, since the DO issue is not resolved yet.

[pmeier]

@iameskild Did you fix the DO token as discussed in yesterday's community meeting? If so, I'm still seeing the same failures on my PR: https://github.com/nebari-dev/nebari/actions/runs/5067342709/jobs/9098287246?pr=1778 Maybe we should open an RFD regarding dropping DO from our supported provider list as @trallard suggested.

[iameskild]

@pmeier the DO API token has been updated and the CI is passing 🎉

[pmeier]

In that case #1820 actually closed this issue.