Skip to content

Commit 73c9028

Browse files
authored
remove usage of SCFDialect (#37)
1 parent f26ad2f commit 73c9028

File tree

4 files changed

+1
-9
lines changed

4 files changed

+1
-9
lines changed

nautilus/src/nautilus/compiler/backends/mlir/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ if (ENABLE_MLIR_BACKEND)
2020
MLIRExecutionEngine
2121
MLIRFuncAllExtensions
2222
# Dialects
23-
MLIRSCFDialect
2423
MLIRFuncToLLVM
25-
MLIRSCFToControlFlow
2624
)
2725

2826
add_source_files(nautilus

nautilus/src/nautilus/compiler/backends/mlir/MLIRLoweringProvider.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#include <mlir/Dialect/Func/IR/FuncOps.h>
1111
#include <mlir/Dialect/LLVMIR/LLVMDialect.h>
1212
#include <mlir/Dialect/LLVMIR/LLVMTypes.h>
13-
#include <mlir/Dialect/SCF/IR/SCF.h>
1413
#include <mlir/IR/Attributes.h>
1514
#include <mlir/IR/Builders.h>
1615
#include <mlir/IR/BuiltinAttributes.h>
@@ -212,7 +211,6 @@ MLIRLoweringProvider::MLIRLoweringProvider(mlir::MLIRContext& context) : context
212211
builder->getContext()->loadDialect<mlir::cf::ControlFlowDialect>();
213212
builder->getContext()->loadDialect<mlir::LLVM::LLVMDialect>();
214213
builder->getContext()->loadDialect<mlir::func::FuncDialect>();
215-
builder->getContext()->loadDialect<mlir::scf::SCFDialect>();
216214
this->theModule = mlir::ModuleOp::create(getNameLoc("module"));
217215
// Store InsertPoint for inserting globals such as Strings or TupleBuffers.
218216
globalInsertPoint = new mlir::RewriterBase::InsertPoint(theModule.getBody(), theModule.begin());

nautilus/src/nautilus/compiler/backends/mlir/MLIRPassManager.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
#include "nautilus/exceptions/NotImplementedException.hpp"
55
#include <mlir/Conversion/ControlFlowToLLVM/ControlFlowToLLVM.h>
66
#include <mlir/Conversion/FuncToLLVM/ConvertFuncToLLVMPass.h>
7-
#include <mlir/Conversion/SCFToControlFlow/SCFToControlFlow.h>
87
#include <mlir/ExecutionEngine/OptUtils.h>
98
#include <mlir/Pass/PassManager.h>
109
#include <mlir/Transforms/Passes.h>
@@ -25,8 +24,6 @@ std::unique_ptr<mlir::Pass> getMLIRLoweringPass(MLIRPassManager::LoweringPass lo
2524
switch (loweringPass) {
2625
case MLIRPassManager::LoweringPass::LLVM:
2726
return mlir::createConvertControlFlowToLLVMPass();
28-
case MLIRPassManager::LoweringPass::SCF:
29-
return mlir::createConvertSCFToCFPass();
3027
}
3128
throw NotImplementedException("pass is not supported");
3229
}
@@ -64,7 +61,6 @@ int MLIRPassManager::lowerAndOptimizeMLIRModule(mlir::OwningOpRef<mlir::ModuleOp
6461
passManager.addPass(getMLIRLoweringPass(loweringPass));
6562
}
6663
} else {
67-
passManager.addPass(mlir::createConvertSCFToCFPass());
6864
passManager.addPass(mlir::createConvertFuncToLLVMPass());
6965
passManager.addPass(mlir::createConvertControlFlowToLLVMPass());
7066
}

nautilus/src/nautilus/compiler/backends/mlir/MLIRPassManager.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace nautilus::compiler::mlir {
99
// and applies configured lowering & optimization passes to it.
1010
class MLIRPassManager {
1111
public:
12-
enum class LoweringPass : uint8_t { SCF, LLVM };
12+
enum class LoweringPass : uint8_t { LLVM };
1313
enum class OptimizationPass : uint8_t { Inline };
1414

1515
MLIRPassManager(); // Disable default constructor

0 commit comments

Comments
 (0)