first commit

Author: PhilippGrulich

CMakeLists.txt

@@ -6,6 +6,8 @@ set(CMAKE_CXX_STANDARD_REQUIRED True)
 set(CATCH_ENABLE_REPRODUCIBLE_BUILD OFF CACHE INTERNAL "Turn off tests")
 #set(NES_WARNINGS "-Wall -Wextra -pedantic -Wno-null-character -Wno-dollar-in-identifier-extension -Werror=extra -Werror=exceptions -Werror=all -Werror=integer-overflow -Werror=return-type -Werror=return-stack-address -Werror=delete-non-virtual-dtor -Werror=deprecated -Werror=writable-strings -Werror=array-bounds -Werror=ignored-qualifiers -Werror=sign-compare -Wno-deprecated-copy-with-dtor -Wno-unused-variable -Wno-unused-but-set-variable -Wno-deprecated-declarations -Wno-invalid-offsetof ")
 
+
+set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Wall -Werror -Wunused -Werror=vla -Wnarrowing -pedantic")
 set(CMAKE_CXX_FLAGS "-fpermissive -fPIC -g")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
 

nautilus-api/src/Interface/DataTypes/MemRefUtils.cpp

@@ -16,6 +16,7 @@
 #include <Interface/DataTypes/MemRefUtils.hpp>
 #include <Interface/FunctionCall.hpp>
 #include <cstring>
+#include "Exceptions/NotImplementedException.hpp"
 
 namespace NES::Nautilus::MemRefUtils {
 
@@ -72,6 +73,8 @@ namespace NES::Nautilus::MemRefUtils {
          }
          NES_NOT_IMPLEMENTED();
          */
+        throw Exceptions::NotImplementedException("No plugin registered that can handle this operation between");
+
     }
 
     bool memeq(void *ptr1, void *ptr2, uint64_t size) { return memcmp(ptr1, ptr2, size) == 0; }

nautilus-api/src/Interface/DataTypes/Value.cpp

@@ -17,6 +17,7 @@
 #include <Interface/DataTypes/Value.hpp>
 #include <Tracing/TraceContext.hpp>
 #include <common/PluginRegistry.hpp>
+#include "Exceptions/NotImplementedException.hpp"
 
 namespace NES::Nautilus {
 
@@ -62,8 +63,8 @@ namespace NES::Nautilus {
                 return result.value();
             }
         };
-        //NES_THROW_RUNTIME_ERROR("No plugin registered that can handle this operation between " << left->toString() << " and "
-        //                                                                                       << right->toString());
+        throw Exceptions::NotImplementedException("No plugin registered that can handle this operation between");
+
     }
 
     Value<> evalWithCast(
@@ -210,7 +211,9 @@ namespace NES::Nautilus {
                 return result.value();
             }
         };
-        //NES_THROW_RUNTIME_ERROR("No plugin registered that can handle this operation");
+        throw Exceptions::NotImplementedException("No plugin registered that can handle this operation between");
+
+
     }
 
     Value<> ReadArrayIndexOp(const Value<> &input, Value<UInt32> &index) {
@@ -221,7 +224,9 @@ namespace NES::Nautilus {
                 return result.value();
             }
         };
-        //NES_THROW_RUNTIME_ERROR("No plugin registered that can handle this operation");
+        throw Exceptions::NotImplementedException("No plugin registered that can handle this operation between");
+
+
     }
 
     void WriteArrayIndexOp(const Value<> &input, Value<UInt32> &index, const Value<> &value) {
@@ -232,7 +237,7 @@ namespace NES::Nautilus {
                 return;
             }
         };
-        //NES_THROW_RUNTIME_ERROR("No plugin registered that can handle this operation");
+
     }
 
 }// namespace NES::Nautilus

nautilus-jit/src/IR/BasicBlocks/BasicBlock.cpp

@@ -17,6 +17,7 @@
 #include <IR/Operations/IfOperation.hpp>
 #include <IR/Operations/Loop/LoopOperation.hpp>
 #include <IR/Operations/Operation.hpp>
+#include <Exceptions/NotImplementedException.hpp>
 #include <algorithm>
 #include <cstdint>
 #include <memory>
@@ -150,9 +151,7 @@ namespace NES::Nautilus::IR {
         } else if (operations.back()->getOperationType() == IR::Operations::Operation::OperationType::ReturnOp) {
             return {};
         } else {
-            //NES_ERROR("BasicBlock::getNextBlocks: Tried to get next block for unsupported operation type: "
-            //          << magic_enum::enum_name(operations.back()->getOperationType()));
-            //NES_NOT_IMPLEMENTED();
+            throw Exceptions::NotImplementedException("BasicBlock::getNextBlocks: Tried to get next block for unsupported operation type.");
         }
     }
 

nautilus-jit/src/Tracing/Phases/TraceToIRConversionPhase.cpp

@@ -331,10 +331,6 @@ namespace NES::Nautilus::Tracing {
                                                                         TraceOperation &operation) {
         auto leftInput = frame.getValue(createValueIdentifier(operation.input[0]));
         auto rightInput = frame.getValue(createValueIdentifier(operation.input[1]));
-
-        NES::Nautilus::IR::Operations::CompareOperation::Comparator comparator;
-        comparator = NES::Nautilus::IR::Operations::CompareOperation::Comparator::LT;
-
         auto resultIdentifier = createValueIdentifier(operation.result);
         auto compareOperation = std::make_shared<NES::Nautilus::IR::Operations::CompareOperation>(
                 resultIdentifier,
@@ -352,9 +348,6 @@ namespace NES::Nautilus::Tracing {
         auto leftInput = frame.getValue(createValueIdentifier(operation.input[0]));
         auto rightInput = frame.getValue(createValueIdentifier(operation.input[1]));
 
-        NES::Nautilus::IR::Operations::CompareOperation::Comparator comparator;
-        comparator = NES::Nautilus::IR::Operations::CompareOperation::Comparator::GT;
-
         auto resultIdentifier = createValueIdentifier(operation.result);
         auto compareOperation = std::make_shared<NES::Nautilus::IR::Operations::CompareOperation>(
                 resultIdentifier,

nautilus-jit/src/Tracing/Tag/TagRecorder.cpp

@@ -15,6 +15,7 @@
 #include <Exceptions/TagCreationException.hpp>
 #include <Tracing/Tag/TagRecorder.hpp>
 #include <execinfo.h>
+#include "Exceptions/NotImplementedException.hpp"
 
 namespace NES::Nautilus::Tracing {
     TagRecorder::TagRecorder(TagAddress startAddress) : startAddress(startAddress) {}
@@ -33,7 +34,8 @@ namespace NES::Nautilus::Tracing {
 #else
 
     TagVector TagRecorder::createBaseTag() {
-        //  NES_NOT_IMPLEMENTED();
+        throw Exceptions::NotImplementedException("No plugin registered that can handle this operation between");
+
     }
 
 #endif

nautilus-jit/src/Tracing/TraceUtil.cpp

@@ -15,6 +15,7 @@
 #include <Interface/DataTypes/Boolean.hpp>
 #include <Tracing/TraceContext.hpp>
 #include <Tracing/TraceUtil.hpp>
+#include "Exceptions/NotImplementedException.hpp"
 
 namespace NES::Nautilus::Tracing::TraceUtil {
 
@@ -42,8 +43,7 @@ namespace NES::Nautilus::Tracing::TraceUtil {
                 return boolValue->getValue();
             }
         }
-
-        // NES_THROW_RUNTIME_ERROR("Can't evaluate bool on non Boolean value: " << value->toString());
+        throw Exceptions::NotImplementedException("Can't evaluate bool on non Boolean value");
     }
 
     void traceAssignmentOperation(const Nautilus::Tracing::ValueRef &targetRef,