first commit

Author: PhilippGrulich

.github/workflows/build.yml

@@ -10,11 +10,6 @@ jobs:
       - run: echo "💡 The ${{ github.repository }} repository has been cloned to the runner."
       - name: get cmake
         uses: lukka/get-cmake@latest
-      - name: Set up Clang
-        uses: egor-tensin/setup-clang@v1
-        with:
-          version: latest
-          platform: x64
       - name: cmake
         shell: bash
         run: |

CMakeLists.txt

@@ -1,12 +1,12 @@
-cmake_minimum_required(VERSION 3.27)
+cmake_minimum_required(VERSION 3.22.1)
 project(nautilus_lib)
 
 set(CMAKE_CXX_STANDARD 20)
 set(CMAKE_CXX_STANDARD_REQUIRED True)
 set(CATCH_ENABLE_REPRODUCIBLE_BUILD OFF CACHE INTERNAL "Turn off tests")
 #set(NES_WARNINGS "-Wall -Wextra -pedantic -Wno-null-character -Wno-dollar-in-identifier-extension -Werror=extra -Werror=exceptions -Werror=all -Werror=integer-overflow -Werror=return-type -Werror=return-stack-address -Werror=delete-non-virtual-dtor -Werror=deprecated -Werror=writable-strings -Werror=array-bounds -Werror=ignored-qualifiers -Werror=sign-compare -Wno-deprecated-copy-with-dtor -Wno-unused-variable -Wno-unused-but-set-variable -Wno-deprecated-declarations -Wno-invalid-offsetof ")
 
-set(CMAKE_CXX_FLAGS "-fpermissive -fPIC")
+set(CMAKE_CXX_FLAGS "-fpermissive -fPIC -g")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++20")
 
 

docker/Dockerfile-NES-Build-ubuntu-22_04

@@ -0,0 +1,12 @@
+FROM ubuntu:latest
+
+RUN apt-get update -qq && DEBIAN_FRONTEND="noninteractive" apt-get install -qq \
+    build-essential \
+    software-properties-common \
+    gcc \
+    g++ \
+    cmake \
+    ccache \
+    gdb-multiarch \
+    gdb \
+    git

nautilus-api/test/CMakeLists.txt

@@ -14,7 +14,7 @@
 add_executable(nautilus-api-tests
         Interface/DataTypeTest2.cpp)
 
-target_link_libraries(nautilus-api-tests PUBLIC "$<LINK_LIBRARY:WHOLE_ARCHIVE,nautilus-api>"  Catch2::Catch2WithMain)
+target_link_libraries(nautilus-api-tests PUBLIC nautilus-api  Catch2::Catch2WithMain)
 list(APPEND CMAKE_MODULE_PATH ${catch2_SOURCE_DIR}/extras)
 include(CTest)
 include(Catch)

nautilus-common/include/common/PluginRegistry.hpp

@@ -31,10 +31,12 @@ template<typename T>
 class PluginRegistry {
 
   private:
-    static inline std::list<std::unique_ptr<T>> items = std::list<std::unique_ptr<T>>();
-
+    static std::list<std::unique_ptr<T>>& getItems() {
+        static std::list<std::unique_ptr<T>> items;
+        return items;
+    }
   public:
-    static std::list<std::unique_ptr<T>>& getPlugins() { return items; }
+    static std::list<std::unique_ptr<T>>& getPlugins() { return getItems(); }
     /** A static registration template. Use like such:
     *
     * Registry<PluginInterfaceType>::Add<PluginType> X;
@@ -48,10 +50,11 @@ class PluginRegistry {
         static std::unique_ptr<T> CtorFn() { return std::make_unique<V>(); }
 
       public:
-        Add() { PluginRegistry<T>::items.emplace_back(CtorFn()); }
+        Add() { getItems().emplace_back(CtorFn()); }
     };
 };
 
+
 /**
  * @brief The plugin registry allows the dynamic registration of plugins at runtime.
  * A plugin is a provider of a specific type T, which defines the plugin interface.