Skip to content

Small ostream fixes #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2024
Merged

Small ostream fixes #46

merged 2 commits into from
Sep 18, 2024

Conversation

keyseven123
Copy link
Contributor

This PR adds std::hex to be used directly in nautilus.

@keyseven123 keyseven123 self-assigned this Sep 18, 2024
@PhilippGrulich
Copy link
Member

Looks good. I think hex is defined in the ios header. Could you move the definitions?

@keyseven123
Copy link
Contributor Author

Sure, I have included ios now

PhilippGrulich
PhilippGrulich approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@PhilippGrulich PhilippGrulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@PhilippGrulich PhilippGrulich merged commit cef3add into main Sep 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippGrulich PhilippGrulich PhilippGrulich approved these changes

Assignees

@keyseven123 keyseven123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keyseven123 @PhilippGrulich