Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests against reading config files #2682

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Conversation

wooseopkim
Copy link
Contributor

@wooseopkim wooseopkim commented Feb 23, 2025

My sinister scheme here is to get #2681 resolved in the end, but this PR is an enhancement regardless of that I guess.

@wooseopkim wooseopkim requested a review from a team as a code owner February 23, 2025 06:57
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, more cmd tests are good. I left an optional enhancement.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.40%. Comparing base (5a80a04) to head (6a2824b).
Report is 178 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2682       +/-   ##
===========================================
+ Coverage   61.56%   74.40%   +12.84%     
===========================================
  Files          53       72       +19     
  Lines        9002    11051     +2049     
===========================================
+ Hits         5542     8223     +2681     
+ Misses       3020     2192      -828     
- Partials      440      636      +196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot requested a review from a team February 23, 2025 11:36
@mergify mergify bot merged commit 404620b into nektos:master Feb 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants