chore: cleanup Areas annotation

Author: DjordyKoert

CHANGELOG.md

@@ -1,5 +1,15 @@
 # CHANGELOG
 
+## 4.36.1
+- Passing an array key `values` with a list of strings to the `Areas` annotation/attribute is deprecated. Pass the list of strings directly.
+```diff
+-#[Areas(properties: ['values' => ['foo', 'bar']])]
++#[Areas(properties: ['foo', 'bar'])]
+
+-#[Areas(['values' => ['foo', 'bar']])]
++#[Areas(['foo', 'bar'])]
+```
+
 ## 4.36.0
 * Configuration option `with_annotation` has been deprecated in favor of `with_attribute`
 ```diff

src/Attribute/Areas.php

@@ -25,26 +25,26 @@ class Areas
      */
     public function __construct(array $properties)
     {
-        if (!array_key_exists('value', $properties) || !is_array($properties['value'])) {
-            $properties['value'] = array_values($properties);
+        if (array_key_exists('value', $properties) && is_array($properties['value'])) {
+            trigger_deprecation('nelmio/api-doc-bundle', '4.36.1', 'Passing an array with key `value` is deprecated, pass the list of strings directly.');
+
+            $this->areas = array_values($properties['value']);
+        } else {
+            $this->areas = [];
+            foreach ($properties as $area) {
+                if (!is_string($area)) {
+                    throw new \InvalidArgumentException('An area must be given as a string');
+                }
+
+                if (!in_array($area, $this->areas, true)) {
+                    $this->areas[] = $area;
+                }
+            }
         }
 
-        if ([] === $properties['value']) {
+        if ([] === $this->areas) {
             throw new \InvalidArgumentException('An array of areas was expected');
         }
-
-        $areas = [];
-        foreach ($properties['value'] as $area) {
-            if (!is_string($area)) {
-                throw new \InvalidArgumentException('An area must be given as a string');
-            }
-
-            if (!in_array($area, $areas, true)) {
-                $areas[] = $area;
-            }
-        }
-
-        $this->areas = $areas;
     }
 
     public function has(string $area): bool