Value map for integer source attribute values not saved and interpreted correctly

[leendertvanwolfswinkel]

Test data

topdesk 2410 0159.zip

Problem description

The configuration JSON in the test data contains this entry for friction_value:

    "friction_value": {
      "method": "source_attribute",
      "source_attribute": "SOORTMATER",
      "value_map": {
        "0": 0.02,
        "1": 0.011,
        "3": 0.02,
        "10": 0.02,
        "11": 0.011,
        "13": 0.011,
        "17": 0.02,
        "20": 0.011,
        "21": 0.011,
        "22": 0.02,
        "28": 0.011,
        "30": 0.02,
        "31": 0.02
      },
      "default_value": 0.02
    },

Note that the values are double-quoted. This is not something the user did, this happens when you save the configuration as a template JSON.

When you import weirs using this configuration, the source attribute values are written as target attribute values, instead of being mapped according to the value map.

The current workaround that the user came up with is to load the template, remove all the double quotes from the value map, and run the import. That workaround works, but is obv. not the desirable way to go.

How to reproduce

• Add stuw_servicedesk.gpkg to the project
• Load a schematisation
• Open the Import weirs dialog
• Choose "stuw_servicedesk" as source layer
• Load template "import weirs V&V.json"
• Import the weirs
• The friction values that are written to new, imported weirs are

Suggested solution

Take the source attribute data type into account when interpreting the values in the value map? Or convert the source attribute value to string before looking it up in the value map?