Fixes #4141: apoc.load.jdbcUpdate inside apoc.periodic.iterate leaves idle connections from 5.19 and forward #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… idle connections from 5.19 and forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4141
The problem should be related to this change, using the
DatabaseConnectionSourcesthe issue error is (flakily) caused,while with
Connectionit works correctly.Strangely using the Postgres' issue version, the error is not replicable via
TestContainer,while can be replicated with the default present version: 9.6.12.
Maybe because the user version has some special configuration, or the test container is slightly different from the non-test version.
In any case, even with that version, the problem occurs infrequently, about 1 time every 10/15, most of the time you get a
“FATAL: sorry, too many clients already”instead of an"idle"connection,which is not the case with the reported changes.
We could also solve the problem by downgrading the
schemacrawlerversion,but it is not recommended, since it has vulnerabilities.