Skip to content

Commit ed4e02b

Browse files
apply another round of XFact's feedback
1 parent 05803d8 commit ed4e02b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/resources/client/models/bakedmodel.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Other methods in `BakedModel` that you may override and/or query include:
4343
| `ItemOverrides getOverrides()` | Returns the [`ItemOverrides`][itemoverrides] associated with this model. This is only relevant on item models. |
4444
| `ModelData getModelData(BlockAndTintGetter, BlockPos, BlockState, ModelData)` | Returns the model data to use for the model. This method is passed an existing `ModelData` that is either the result of `BlockEntity#getModelData()` if the block has an associated block entity, or `ModelData.EMPTY` if that is not the case. This method can be used for blocks that need model data, but do not have a block entity, for example for blocks with connected textures. |
4545
| `TextureAtlasSprite getParticleIcon(ModelData)` | Returns the particle sprite to use for the model. May use the model data to use different particle sprites for different model data values. NeoForge-added, replacing the vanilla `getParticleIcon()` overload with no parameters. |
46-
| `ChunkRenderTypeSet getRenderTypes(BlockState, RandomSource, ModelData)` | Returns a `ChunkRenderTypeSet` containing the render type(s) to use for rendering the block model. By default falls back to the normal model-bound render type lookup, which always yields a set with one element. Note that `ChunkRenderTypeSet` is not actually a set, but an ordered `Iterable<List>` (so more of a list). Only used for block models, item models use the overload below. |
46+
| `ChunkRenderTypeSet getRenderTypes(BlockState, RandomSource, ModelData)` | Returns a `ChunkRenderTypeSet` containing the render type(s) to use for rendering the block model. A `ChunkRenderTypeSet` is a set-backed ordered `Iterable<RenderType>`. By default falls back to [getting the render type from the model JSON][rendertype]. Only used for block models, item models use the overload below. |
4747
| `List<RenderType> getRenderTypes(ItemStack, boolean)` | Returns a `List<RenderType>` containing the render type(s) to use for rendering the item model. By default falls back to the normal model-bound render type lookup, which always yields a list with one element. Only used for item models, block models use the overload above. |
4848

4949
## Perspectives
@@ -115,7 +115,7 @@ public static void modifyBakingResult(ModelEvent.ModifyBakingResult event) {
115115
```
116116

117117
:::warning
118-
It is generally encouraged to use a [custom model loader][modelloader] over baked model wrappers when possible. Custom model loaders can also use `BakedModelWrapper`s if needed.
118+
It is generally encouraged to use a [custom model loader][modelloader] over wrapping baked models in `ModelEvent.ModifyBakingResult` when possible. Custom model loaders can also use `BakedModelWrapper`s if needed.
119119
:::
120120

121121
[ao]: https://en.wikipedia.org/wiki/Ambient_occlusion

0 commit comments

Comments
 (0)