Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker.App: onOrientationChange() => limit the scope to affected windows #5728

Open
tobiu opened this issue Aug 9, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request no auto close

Comments

@tobiu
Copy link
Collaborator

tobiu commented Aug 9, 2024

@Dinkh: adding an orientationchange notification for apps is a good idea in general.

however, the multi-window aspect probably should get honored.

tricky one: we could argue that the event can only happen on mobile where all windows are affected anyway.

edge-case: desktop, where you debug a specific window in the mobile view and switch the orientation there. in this case, other windows are not affected.

low prio.

@tobiu tobiu added the enhancement New feature or request label Aug 9, 2024
@Dinkh
Copy link
Contributor

Dinkh commented Aug 10, 2024

@tobiu In fact this will only affect Desktop. And for desktop it seems more likely to use responsive settings than orientationchange.

For Tablets and Phone this should not matter, as you cannot have resizable windows.

I would argue, that this issue should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no auto close
Projects
None yet
Development

No branches or pull requests

2 participants