From 358645969d6c2d700f15f791bd0633b6216ffe39 Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Sun, 26 Jan 2025 16:44:07 +0100 Subject: [PATCH] TASK: Replace leftover usages of if possible --- .../Drawer/UserDropDown/RestoreButtonItem.js | 10 +--- .../Containers/Drawer/UserDropDown/index.js | 6 +-- .../src/Containers/Modals/InsertMode/index.js | 53 +++++-------------- .../Modals/KeyboardShortcutModal/index.js | 8 +-- .../Modals/NodeCreationDialog/index.js | 2 +- .../Modals/NodeVariantCreationDialog/index.js | 10 ++-- 6 files changed, 30 insertions(+), 59 deletions(-) diff --git a/packages/neos-ui/src/Containers/Drawer/UserDropDown/RestoreButtonItem.js b/packages/neos-ui/src/Containers/Drawer/UserDropDown/RestoreButtonItem.js index fa987c633a..80b80e9b52 100644 --- a/packages/neos-ui/src/Containers/Drawer/UserDropDown/RestoreButtonItem.js +++ b/packages/neos-ui/src/Containers/Drawer/UserDropDown/RestoreButtonItem.js @@ -4,7 +4,7 @@ import PropTypes from 'prop-types'; import {Icon} from '@neos-project/react-ui-components'; import {connect} from 'react-redux'; import {actions} from '@neos-project/neos-ui-redux-store'; -import I18n, {translate} from '@neos-project/neos-ui-i18n'; +import {translate} from '@neos-project/neos-ui-i18n'; import buttonTheme from './style.module.css'; @@ -39,13 +39,7 @@ export default class RestoreButtonItem extends React.PureComponent { aria-hidden="true" className={buttonTheme.dropDown__itemIcon} /> - + {translate('Neos.Neos:Main:impersonate.label.restoreUserButton', 'Back to user "{0}"', {0: originUser.fullName})} ) : null); diff --git a/packages/neos-ui/src/Containers/Drawer/UserDropDown/index.js b/packages/neos-ui/src/Containers/Drawer/UserDropDown/index.js index 18efa136ab..c576700985 100644 --- a/packages/neos-ui/src/Containers/Drawer/UserDropDown/index.js +++ b/packages/neos-ui/src/Containers/Drawer/UserDropDown/index.js @@ -7,7 +7,7 @@ import {Icon, DropDown} from '@neos-project/react-ui-components'; import UserImage from './UserImage'; import RestoreButtonItem from './RestoreButtonItem'; -import I18n from '@neos-project/neos-ui-i18n'; +import {translate} from '@neos-project/neos-ui-i18n'; import style from './style.module.css'; @connect(state => ({ @@ -36,7 +36,7 @@ export default class UserDropDown extends PureComponent {
  • @@ -44,7 +44,7 @@ export default class UserDropDown extends PureComponent {
  • diff --git a/packages/neos-ui/src/Containers/Modals/InsertMode/index.js b/packages/neos-ui/src/Containers/Modals/InsertMode/index.js index 2ecf952785..f85057d592 100644 --- a/packages/neos-ui/src/Containers/Modals/InsertMode/index.js +++ b/packages/neos-ui/src/Containers/Modals/InsertMode/index.js @@ -5,7 +5,7 @@ import {connect} from 'react-redux'; import {neos} from '@neos-project/neos-ui-decorators'; import {Button, Dialog, Icon} from '@neos-project/react-ui-components'; -import I18n, {translate} from '@neos-project/neos-ui-i18n'; +import {translate} from '@neos-project/neos-ui-i18n'; import {InsertModeSelector} from '@neos-project/neos-ui-containers'; @@ -81,41 +81,22 @@ export default class InsertModeModal extends PureComponent { renderTitle() { const {subjectContextPaths, referenceContextPath, operationType} = this.props; - + const parameters = { + source: this.renderNodeLabel(subjectContextPaths), + target: this.renderNodeLabel([referenceContextPath]) + }; + + let label = ''; + if (operationType === actionTypes.CR.Nodes.COPY) { + label = translate('Neos.Neos:Main:copy__from__to--title', '', parameters); + } else if (operationType === actionTypes.CR.Nodes.CUT || operationType === actionTypes.CR.Nodes.MOVE) { + label = translate('Neos.Neos:Main:move__from__to--title', '', parameters); + } return (
    - {operationType === actionTypes.CR.Nodes.COPY && - - } - {operationType === actionTypes.CR.Nodes.CUT && - - } - {operationType === actionTypes.CR.Nodes.MOVE && - - } + {label}
    ); @@ -173,13 +154,7 @@ export default class InsertModeModal extends PureComponent { >

    - + {translate('Neos.Neos:Main:copy__from__to--description', '', {source: this.renderNodeLabel(subjectContextPaths), target: this.renderNodeLabel([referenceContextPath])})}

    (
    - + {translate(`Neos.Neos.Ui:Main:Shortcut__${id}`, description)}
    {keys}
    @@ -52,12 +52,12 @@ class KeyboardShortcutModal extends PureComponent { return ( } + title="Keyboard Shortcuts" isOpen={isOpen} onRequestClose={() => close()} >
    - + {translate('Neos.Neos.Ui:Main:Shortcut__Introduction')}
    {hotkeyRegistry.getAllAsList().map(key => this.renderShortcut(key))} diff --git a/packages/neos-ui/src/Containers/Modals/NodeCreationDialog/index.js b/packages/neos-ui/src/Containers/Modals/NodeCreationDialog/index.js index 514ba359ab..7f266041ea 100644 --- a/packages/neos-ui/src/Containers/Modals/NodeCreationDialog/index.js +++ b/packages/neos-ui/src/Containers/Modals/NodeCreationDialog/index.js @@ -220,7 +220,7 @@ export default class NodeCreationDialog extends PureComponent { return ( -   + {translate('Neos.Neos:Main:createNew', 'Create new')}  ); diff --git a/packages/neos-ui/src/Containers/Modals/NodeVariantCreationDialog/index.js b/packages/neos-ui/src/Containers/Modals/NodeVariantCreationDialog/index.js index d577cae831..3ade0e2dc4 100644 --- a/packages/neos-ui/src/Containers/Modals/NodeVariantCreationDialog/index.js +++ b/packages/neos-ui/src/Containers/Modals/NodeVariantCreationDialog/index.js @@ -3,7 +3,7 @@ import PropTypes from 'prop-types'; import {connect} from 'react-redux'; import {Button, Dialog} from '@neos-project/react-ui-components'; -import I18n, {translate} from '@neos-project/neos-ui-i18n'; +import {translate} from '@neos-project/neos-ui-i18n'; import {selectors, actions} from '@neos-project/neos-ui-redux-store'; import {neos} from '@neos-project/neos-ui-decorators'; @@ -147,14 +147,16 @@ export default class NodeVariantCreationDialog extends PureComponent { >
    - + {translate('Neos.Neos:Main:content.dimension.createDialog.nodeTypeDoesNotExistInDimension', '', i18nParams)}
    - + {translate('Neos.Neos:Main:content.dimension.createDialog.createEmptyOrCopy', '', i18nParams)}
    {numberOfParentNodesToBeCreated > 0 ? -
    : null +
    + {translate('Neos.Neos:Main:content.dimension.createDialog.existingAncestorDocuments', '', {numberOfNodesMissingInRootline: numberOfParentNodesToBeCreated})} +
    : null }