Merge pull request #3659 from neos/bugfix/feedbacks-with-optional-properties

ahaeslich · web-flow · commit f332d9f4cdba · 2023-11-01T11:39:51.000+01:00
BUGFIX: Feedbacks have null defaults for optional properties
diff --git a/Classes/Domain/Model/AbstractChange.php b/Classes/Domain/Model/AbstractChange.php
@@ -27,7 +27,7 @@ abstract class AbstractChange implements ChangeInterface
 {
     use NodeTypeWithFallbackProvider;
 
-    protected ?Node $subject;
+    protected ?Node $subject = null;
 
     #[Flow\Inject]
     protected ContentRepositoryRegistry $contentRepositoryRegistry;
diff --git a/Classes/Domain/Model/Changes/AbstractCreate.php b/Classes/Domain/Model/Changes/AbstractCreate.php
@@ -29,7 +29,7 @@ abstract class AbstractCreate extends AbstractStructuralChange
     /**
      * The type of the node that will be created
      */
-    protected ?NodeTypeName $nodeTypeName;
+    protected ?NodeTypeName $nodeTypeName = null;
 
     /**
      * Incoming data from creationDialog
diff --git a/Classes/Domain/Model/Changes/CopyInto.php b/Classes/Domain/Model/Changes/CopyInto.php
@@ -21,7 +21,7 @@ class CopyInto extends AbstractStructuralChange
 {
     protected ?string $parentContextPath;
 
-    protected ?Node $cachedParentNode;
+    protected ?Node $cachedParentNode = null;
 
     public function setParentContextPath(string $parentContextPath): void
     {
diff --git a/Classes/Domain/Model/Feedback/Operations/ReloadContentOutOfBand.php b/Classes/Domain/Model/Feedback/Operations/ReloadContentOutOfBand.php
@@ -28,7 +28,7 @@
 
 class ReloadContentOutOfBand extends AbstractFeedback
 {
-    protected ?Node $node;
+    protected ?Node $node = null;
 
     protected ?RenderedNodeDomAddress $nodeDomAddress;
 
diff --git a/Classes/Domain/Model/Feedback/Operations/ReloadDocument.php b/Classes/Domain/Model/Feedback/Operations/ReloadDocument.php
@@ -23,7 +23,7 @@
 
 class ReloadDocument extends AbstractFeedback
 {
-    protected ?Node $node;
+    protected ?Node $node = null;
 
     #[Flow\Inject]
     protected ContentRepositoryRegistry $contentRepositoryRegistry;
diff --git a/Classes/Domain/Model/Feedback/Operations/UpdateNodeInfo.php b/Classes/Domain/Model/Feedback/Operations/UpdateNodeInfo.php
@@ -23,7 +23,7 @@
 
 class UpdateNodeInfo extends AbstractFeedback
 {
-    protected ?Node $node;
+    protected ?Node $node = null;
 
     /**
      * @Flow\Inject
diff --git a/Classes/Domain/Model/Feedback/Operations/UpdateWorkspaceInfo.php b/Classes/Domain/Model/Feedback/Operations/UpdateWorkspaceInfo.php
@@ -23,7 +23,7 @@
 
 class UpdateWorkspaceInfo extends AbstractFeedback
 {
-    protected ?WorkspaceName $workspaceName;
+    protected ?WorkspaceName $workspaceName = null;
 
     /**
      * @Flow\Inject

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ abstract class AbstractChange implements ChangeInterface`
`27`	`27`	`{`
`28`	`28`	`use NodeTypeWithFallbackProvider;`
`29`	`29`
`30`		`- protected ?Node $subject;`
	`30`	`+ protected ?Node $subject = null;`
`31`	`31`
`32`	`32`	`#[Flow\Inject]`
`33`	`33`	`protected ContentRepositoryRegistry $contentRepositoryRegistry;`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class CopyInto extends AbstractStructuralChange`
`21`	`21`	`{`
`22`	`22`	`protected ?string $parentContextPath;`
`23`	`23`
`24`		`- protected ?Node $cachedParentNode;`
	`24`	`+ protected ?Node $cachedParentNode = null;`
`25`	`25`
`26`	`26`	`public function setParentContextPath(string $parentContextPath): void`
`27`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@`
`28`	`28`
`29`	`29`	`class ReloadContentOutOfBand extends AbstractFeedback`
`30`	`30`	`{`
`31`		`- protected ?Node $node;`
	`31`	`+ protected ?Node $node = null;`
`32`	`32`
`33`	`33`	`protected ?RenderedNodeDomAddress $nodeDomAddress;`
`34`	`34`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`
`24`	`24`	`class ReloadDocument extends AbstractFeedback`
`25`	`25`	`{`
`26`		`- protected ?Node $node;`
	`26`	`+ protected ?Node $node = null;`
`27`	`27`
`28`	`28`	`#[Flow\Inject]`
`29`	`29`	`protected ContentRepositoryRegistry $contentRepositoryRegistry;`